third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: offscreenCanvas.getContext('webgl') crashes on worker Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description("Tests basic functionalities of offscreenCanvas.getContext on the ma in thread");	4 description("Tests basic functionalities of offscreenCanvas.getContext on the ma in thread");

5	5

6 // Tests onstructor of OffscreenCanvas and length/width change	6 // Tests onstructor of OffscreenCanvas and length/width change

7 var aCanvas = new OffscreenCanvas(40, 60);	7 var aCanvas = new OffscreenCanvas(40, 60);

8 shouldBe("aCanvas.width", "40");	8 shouldBe("aCanvas.width", "40");

9 shouldBe("aCanvas.height", "60");	9 shouldBe("aCanvas.height", "60");

10	10

(...skipping 14 matching lines...) Expand all Loading...
25 var ctx2 = aCanvas.getContext("webgl");	25 var ctx2 = aCanvas.getContext("webgl");

26 shouldBeNull("ctx2");	26 shouldBeNull("ctx2");

27	27

28 // Calling getContext on the same context type will return the original context type	28 // Calling getContext on the same context type will return the original context type

29 var ctx3 = aCanvas.getContext("2d");	29 var ctx3 = aCanvas.getContext("2d");

30 shouldBeNonNull("ctx3");	30 shouldBeNonNull("ctx3");

31 shouldBeTrue("ctx3 == ctx");	31 shouldBeTrue("ctx3 == ctx");

32	32

33 // TODO: change the below part of the test when webgl is supported.	33 // TODO: change the below part of the test when webgl is supported.

34 // Calling getContext on an unimplemented context type will return null	34 // Calling getContext on an unimplemented context type will return null

35 var bogusCanvas = new OffscreenCanvas(20, 20);	35 var bCanvas = new OffscreenCanvas(20, 20);

36 var bogusCtx = bogusCanvas.getContext("webgl");	36 var ctx4 = bCanvas.getContext("webgl");
	Justin Novosad 2016/04/20 20:07:27 Hmmm... test is called "getContext2D" but it cover Hmmm... test is called "getContext2D" but it covers webgl too. xidachen 2016/04/20 20:52:09 Good catch, this will be changed in a future CL on Show quoted text On 2016/04/20 20:07:27, Justin Novosad wrote: > Hmmm... test is called "getContext2D" but it covers webgl too. Good catch, this will be changed in a future CL once I fix crash.
37 shouldBeNull("bogusCtx");	37 shouldBeType("ctx4", "WebGLRenderingContext");

38 </script>	38 </script>

OLD	NEW