Use correct target for app_list_shower_unittests.

Use correct target for app_list_shower_unittests.

Follow-up to https://codereview.chromium.org/1875743002. Should fix
ClangToTLinux bot.

BUG=557408
R=hans@chromium.org,thakis@chromium.org

Committed: https://crrev.com/3f57662c89f0ab2cabd4840bff52b6376faf5555
Cr-Commit-Position: refs/heads/master@{#386501}

[Nico, 2016-04-11 18:47:37]

thanks! lgtm with comment addressed

https://codereview.chromium.org/1881553003/diff/1/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1881553003/diff/1/build/gn_migration.gypi#new...
build/gn_migration.gypi:625: '../ui/wm/wm.gyp:wm_unittests_run',
the _run targets all live down here -- can you move the line to here?

[pcc1, 2016-04-11 18:55:09]

https://codereview.chromium.org/1881553003/diff/1/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1881553003/diff/1/build/gn_migration.gypi#new...
build/gn_migration.gypi:625: '../ui/wm/wm.gyp:wm_unittests_run',
On 2016/04/11 18:47:37, Nico wrote:
> the _run targets all live down here -- can you move the line to here?

Done.

[pcc1, 2016-04-11 18:55:21]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2016-04-11 18:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1881553003/#ps20001
(title: "move line")

[commit-bot: I haz the power, 2016-04-11 18:56:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881553003/20001

[commit-bot: I haz the power, 2016-04-11 22:37:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 22:38:40]

Description was changed from

==========
Use correct target for app_list_shower_unittests.

Follow-up to https://codereview.chromium.org/1875743002. Should fix
ClangToTLinux bot.

BUG=557408
R=hans@chromium.org,thakis@chromium.org
==========

to

==========
Use correct target for app_list_shower_unittests.

Follow-up to https://codereview.chromium.org/1875743002. Should fix
ClangToTLinux bot.

BUG=557408
R=hans@chromium.org,thakis@chromium.org

Committed: https://crrev.com/3f57662c89f0ab2cabd4840bff52b6376faf5555
Cr-Commit-Position: refs/heads/master@{#386501}
==========

[commit-bot: I haz the power, 2016-04-11 22:38:41]

Patchset 2 (id:??) landed as
https://crrev.com/3f57662c89f0ab2cabd4840bff52b6376faf5555
Cr-Commit-Position: refs/heads/master@{#386501}

[mfomitchev, 2016-04-12 01:53:36]

mfomitchev@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mfomitchev, 2016-04-12 01:53:37]

https://codereview.chromium.org/1881553003/diff/20001/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1881553003/diff/20001/build/gn_migration.gypi...
build/gn_migration.gypi:623:
'../ui/app_list/shower/app_list_shower.gyp:app_list_shower_unittests_run',
I don't really understand the subtleties here, but for aura unittests we have
both aura_unittests and aura_unittests_run in the dependencies. Shouldn't we
similarly have both app_list_shower_unittests_run and app_list_shower_unittests?
Or is the aura_unittests dependency superfluous?

[Nico, 2016-04-12 02:07:22]

What's in here is part of the 'all' target. This adds the _run target to all,
and the _run target depends on the unit test itself, so after this cl building
'all' should build the test and then its isolate. So listing both isn't needed
(on boths that build isolates).

[mfomitchev, 2016-04-12 03:00:49]

Ok, thanks, that makes sense, but why is it then that for other tests
we list both xyz and xyz_run here? E.g.aura_unittests_run depends on
aura_unittests, but we list both of them here. Same for wm_unittests,
content_browsertests, etc, etc.