Fix isolate_tests after https://codereview.chromium.org/1830293002

Fix isolate_tests after https://codereview.chromium.org/1830293002

BUG=557408
Committed: https://crrev.com/bb7e857fc6e81c40b2b76a90e03d553eb9e682ed
Cr-Commit-Position: refs/heads/master@{#386127}

[hans, 2016-04-08 15:29:37]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2016-04-08 15:29:37]

Please take a look.

[Nico, 2016-04-08 16:57:40]

lgtm

[Nico, 2016-04-08 16:57:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-04-08 16:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875743002/1

[commit-bot: I haz the power, 2016-04-08 18:11:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 18:12:50]

Description was changed from

==========
Fix isolate_tests after https://codereview.chromium.org/1830293002

BUG=557408
==========

to

==========
Fix isolate_tests after https://codereview.chromium.org/1830293002

BUG=557408

Committed: https://crrev.com/bb7e857fc6e81c40b2b76a90e03d553eb9e682ed
Cr-Commit-Position: refs/heads/master@{#386127}
==========

[commit-bot: I haz the power, 2016-04-08 18:12:51]

Patchset 1 (id:??) landed as
https://crrev.com/bb7e857fc6e81c40b2b76a90e03d553eb9e682ed
Cr-Commit-Position: refs/heads/master@{#386127}

[Nico, 2016-04-08 21:38:09]

mfomitchev fyi

[mfomitchev, 2016-04-08 22:24:01]

On 2016/04/08 21:38:09, Nico (hiding until Fri) wrote:
> mfomitchev fyi

Do you mind elaborating what was the exact failure that this fixed (so that I am
less likely to break it in the future:))? Is there a link to a failed bot? I
guess this is not tested by trybots?

[hans, 2016-04-11 17:37:49]

On 2016/04/08 22:24:01, mfomitchev wrote:
> On 2016/04/08 21:38:09, Nico (hiding until Fri) wrote:
> > mfomitchev fyi
> 
> Do you mind elaborating what was the exact failure that this fixed (so that I
am
> less likely to break it in the future:))? Is there a link to a failed bot? I
> guess this is not tested by trybots?

It's failing again now, presumably after fixing my fix:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4875/...

[Nico, 2016-04-11 17:42:04]

https://codereview.chromium.org/1875743002/diff/1/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1875743002/diff/1/build/gn_migration.gypi#new...
build/gn_migration.gypi:344:
'../ui/app_list/shower/app_list_shower.gyp:app_list_shower_unittests',
sorry, i didn't look at this carefully. this must be
app_list_shower_unittests_run, not app_list_shower_unittests

[pcc1, 2016-04-11 18:43:50]

pcc@chromium.org changed reviewers:
+ pcc@chromium.org

[pcc1, 2016-04-11 18:43:51]

https://codereview.chromium.org/1875743002/diff/1/build/gn_migration.gypi
File build/gn_migration.gypi (right):

https://codereview.chromium.org/1875743002/diff/1/build/gn_migration.gypi#new...
build/gn_migration.gypi:344:
'../ui/app_list/shower/app_list_shower.gyp:app_list_shower_unittests',
Mailed https://codereview.chromium.org/1881553003 with this fix