Issue 1881553002: Revert "Steps towards making the convert library strong-mode compliant."

Issue 1881553002: Revert "Steps towards making the convert library strong-mode compliant." (Closed)

Created:
4 years, 8 months ago by floitsch

Modified:
4 years, 8 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Steps towards making the convert library strong-mode compliant." This reverts commit 4ab1219bf93a33a2a3d4803e053ccd70ce190371. Committed: https://github.com/dart-lang/sdk/commit/045a3753665268761508c8053e0ee84372d9ef35

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -137 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/channel/channel.dart	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	runtime/lib/convert_patch.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/convert/ascii.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/convert/base64.dart	View	3 chunks	+10 lines, -5 lines	0 comments	Download
M	sdk/lib/convert/chunked_conversion.dart	View	4 chunks	+3 lines, -72 lines	0 comments	Download
M	sdk/lib/convert/converter.dart	View	2 chunks	+8 lines, -12 lines	0 comments	Download
M	sdk/lib/convert/encoding.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/convert/html_escape.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/convert/json.dart	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/convert/latin1.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/convert/line_splitter.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/convert/utf.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/io/data_transformer.dart	View	6 chunks	+6 lines, -8 lines	0 comments	Download
M	tests/lib/convert/chunked_conversion1_test.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

Committed patchset #1 (id:1) manually as 045a3753665268761508c8053e0ee84372d9ef35 (presubmit successful).

4 years, 8 months ago (2016-04-11 17:53:03 UTC) #4

Message was sent while issue was closed.

lgtm