Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: sdk/lib/convert/chunked_conversion.dart

Issue 1881553002: Revert "Steps towards making the convert library strong-mode compliant." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/convert/base64.dart ('k') | sdk/lib/convert/converter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/convert/chunked_conversion.dart
diff --git a/sdk/lib/convert/chunked_conversion.dart b/sdk/lib/convert/chunked_conversion.dart
index 216cafe43dadee2ed34f4f843b2a210de7b25364..4c962eb62c589db90f57512002408d7f12e931be 100644
--- a/sdk/lib/convert/chunked_conversion.dart
+++ b/sdk/lib/convert/chunked_conversion.dart
@@ -7,57 +7,6 @@ part of dart.convert;
typedef void _ChunkedConversionCallback<T>(T accumulated);
/**
- * A converter that supports chunked conversions.
- *
- * In addition to immediate conversions from [S] to [T], a chunked converter
- * also supports longer-running conversions from [S2] to [T2].
- *
- * Frequently, the source and target types are the same, but this is not a
- * requirement. In particular, converters that work with lists in the
- * immediate conversion, could flatten the type for the chunked conversion.
- *
- * For example, the [LineSplitter] class returns a `List<String>` for the
- * immediate conversion, but returns individual `String`s in the chunked
- * conversion.
- */
-abstract class ChunkedConverter<S, T, S2, T2> extends Converter<S, T> {
-
- const ChunkedConverter();
-
- /**
- * Starts a chunked conversion.
- *
- * The returned sink serves as input for the long-running conversion. The
- * given [sink] serves as output.
- */
- ChunkedConversionSink<S2> startChunkedConversion(Sink<T2> sink) {
- throw new UnsupportedError(
- "This converter does not support chunked conversions: $this");
- }
-
- Stream<T2> bind(Stream<S2> stream) {
- return new Stream<T2>.eventTransformed(
- stream,
- (EventSink<T2> sink) =>
- new _ConverterStreamEventSink<S2, T2>(this, sink));
- }
-
- /**
- * Fuses this instance with the given [other] converter.
- *
- * If [other] is a ChunkedConverter (with matching generic types), returns a
- * [ChunkedConverter].
- */
- Converter<S, dynamic> fuse(Converter<T, dynamic> other) {
- if (other is ChunkedConverter<T, dynamic, T2, dynamic>) {
- return new _FusedChunkedConverter<S, T, dynamic, S2, T2, dynamic>(
- this, other);
- }
- return super.fuse(other);
- }
-}
-
-/**
* A [ChunkedConversionSink] is used to transmit data more efficiently between
* two converters during chunked conversions.
*
@@ -106,7 +55,7 @@ class _SimpleCallbackSink<T> extends ChunkedConversionSink<T> {
}
/**
- * This class implements the logic for a chunked conversion as a
+ * This class converts implements the logic for a chunked conversion as a
* stream transformer.
*
* It is used as strategy in the [EventTransformStream].
@@ -122,10 +71,9 @@ class _ConverterStreamEventSink<S, T> implements EventSink<S> {
* The input sink for new data. All data that is received with
* [handleData] is added into this sink.
*/
- ChunkedConversionSink<S> _chunkedSink;
+ ChunkedConversionSink _chunkedSink;
- _ConverterStreamEventSink(
- ChunkedConverter<dynamic, dynamic, S, T> converter, EventSink<T> sink)
+ _ConverterStreamEventSink(Converter converter, EventSink<T> sink)
: this._eventSink = sink,
_chunkedSink = converter.startChunkedConversion(sink);
@@ -135,20 +83,3 @@ class _ConverterStreamEventSink<S, T> implements EventSink<S> {
}
void close() => _chunkedSink.close();
}
-
-/**
- * Fuses two chunked converters.
- */
-class _FusedChunkedConverter<S, M, T, S2, M2, T2> extends
- ChunkedConverter<S, T, S2, T2> {
- final ChunkedConverter<S, M, S2, M2> _first;
- final ChunkedConverter<M, T, M2, T2> _second;
-
- _FusedChunkedConverter(this._first, this._second);
-
- T convert(S input) => _second.convert(_first.convert(input));
-
- ChunkedConversionSink<S2> startChunkedConversion(Sink<T2> sink) {
- return _first.startChunkedConversion(_second.startChunkedConversion(sink));
- }
-}
« no previous file with comments | « sdk/lib/convert/base64.dart ('k') | sdk/lib/convert/converter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698