Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1881373002: CC Animation: Erase AnimationRegistrar (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@private
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase AnimationRegistrar Merge AnimationRegistrar into AnimationHost. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2 Cr-Commit-Position: refs/heads/master@{#387197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -306 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/animation_host.h View 6 chunks +18 lines, -11 lines 0 comments Download
M cc/animation/animation_host.cc View 5 chunks +100 lines, -25 lines 0 comments Download
D cc/animation/animation_registrar.h View 1 chunk +0 lines, -92 lines 0 comments Download
D cc/animation/animation_registrar.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M cc/animation/element_animations.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/layer_animation_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-13 05:39:33 UTC) #4
Ian Vollick
On 2016/04/13 05:39:33, loyso wrote: lgtm.
4 years, 8 months ago (2016-04-13 13:10:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881373002/1
4 years, 8 months ago (2016-04-14 00:40:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 01:33:58 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:35:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2
Cr-Commit-Position: refs/heads/master@{#387197}

Powered by Google App Engine
This is Rietveld 408576698