Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1881343003: Fix the scroll and zoom (Closed)

Created:
4 years, 8 months ago by sgurun-gerrit only
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix the scroll and zoom BUG=602760 In a previous code change, the scroll and zoom parameters were placed out of their place. Unfortunately this caused the coordinates to be be wrong when scroll and zoom is done. This CL fixes it. Writing an integration test seemed more complicated then it is. The most suitable test location to confirm the parameters is onProvideVirtualStructure() method right before creating the Android ViewStructure. However, this structure does not seem to be mockable. I will look for a better testing (or perhaps refactoring the code) in a next CL. But this CL needs to be mergeable to 51 so not doing it here. Review URL: https://codereview.chromium.org/1882283002 Cr-Commit-Position: refs/heads/master@{#386875} (cherry picked from commit 93c4e8bb9c0418a3822d30428cd6c2d59eff0a40) Committed: https://chromium.googlesource.com/chromium/src/+/f93c1da191008f0badde61c140c3765fe14013d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/web_contents/web_contents_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
sgurun-gerrit only
4 years, 8 months ago (2016-04-13 22:47:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f93c1da191008f0badde61c140c3765fe14013d6.

Powered by Google App Engine
This is Rietveld 408576698