Fix the scroll and zoom

Fix the scroll and zoom

BUG=602760
In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.

Committed: https://crrev.com/93c4e8bb9c0418a3822d30428cd6c2d59eff0a40
Cr-Commit-Position: refs/heads/master@{#386875}

[sgurun-gerrit only, 2016-04-12 22:33:35]

Description was changed from

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.
==========

to

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.
==========

[sgurun-gerrit only, 2016-04-12 22:33:35]

sgurun@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[sgurun-gerrit only, 2016-04-12 22:34:25]

On 2016/04/12 22:33:35, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:dmazzoni@chromium.org

dmazzoni@ can you please do a review. Ted seems to be OOO, so I will ask a
content owner to stamp after your review.

[dmazzoni, 2016-04-12 23:11:07]

lgtm

[sgurun-gerrit only, 2016-04-12 23:12:17]

sgurun@chromium.org changed reviewers:
+ sievers@chromium.org

[sgurun-gerrit only, 2016-04-12 23:12:40]

On 2016/04/12 23:11:07, dmazzoni wrote:
> lgtm

sievers, Ted is OOO, need a content owner's stamp

[no sievers, 2016-04-12 23:14:14]

lgtm

[sgurun-gerrit only, 2016-04-12 23:27:55]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2016-04-12 23:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882283002/20001

[commit-bot: I haz the power, 2016-04-13 00:30:23]

Description was changed from

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.
==========

to

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.
==========

[commit-bot: I haz the power, 2016-04-13 00:30:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 00:31:43]

Description was changed from

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.
==========

to

==========
Fix the scroll and zoom

BUG=602760

In a previous code change, the scroll and zoom parameters were placed out
of their place. Unfortunately this caused the coordinates to be be wrong
when scroll and zoom is done. This CL fixes it.

Writing an integration test seemed more complicated then it is. The most
suitable test location to confirm the parameters is
onProvideVirtualStructure() method right before creating the Android
ViewStructure. However, this structure does not seem to be mockable.

I will look for a better testing (or perhaps refactoring the code)
in a next CL. But this CL needs to be mergeable to 51 so not doing it
here.

Committed: https://crrev.com/93c4e8bb9c0418a3822d30428cd6c2d59eff0a40
Cr-Commit-Position: refs/heads/master@{#386875}
==========

[commit-bot: I haz the power, 2016-04-13 00:31:44]

Patchset 2 (id:??) landed as
https://crrev.com/93c4e8bb9c0418a3822d30428cd6c2d59eff0a40
Cr-Commit-Position: refs/heads/master@{#386875}