unbundle: add shim_headers.gni and unbundled GN file for zlib

unbundle: add shim_headers.gni and unbundled GN file for zlib

BUG=551343
R=brettw@chromium.org, dpranke@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/8c08dc447bb30eef98be3ff6d66205df611ddb9d

[Paweł Hajdan Jr., 2016-04-13 11:03:30]

phajdan.jr@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, thestig@chromium.org

[Paweł Hajdan Jr., 2016-04-13 11:03:31]

Please note that build/linux/unbundle is never used by Chrome or Chromium builds
on our bots. It's only optionally used by open source distro packagers.

For more context, please see:

https://codereview.chromium.org/1856753003

https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...

https://codereview.chromium.org/11470020

https://bugs.chromium.org/p/chromium/issues/detail?id=165264

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/yJ5P0WMRD8k/zmoKh...

Any suggestions or questions are welcome.

[Paweł Hajdan Jr., 2016-04-13 11:03:36]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 11:03:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881263003/1

[commit-bot: I haz the power, 2016-04-13 11:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 11:40:24]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-04-14 02:45:27]

lgtm

[brettw, 2016-04-14 20:20:07]

lgtm

https://codereview.chromium.org/1881263003/diff/20001/build/linux/unbundle/zl...
File build/linux/unbundle/zlib.gn (right):

https://codereview.chromium.org/1881263003/diff/20001/build/linux/unbundle/zl...
build/linux/unbundle/zlib.gn:12: static_library("zlib") {
This should be a source_set.

https://codereview.chromium.org/1881263003/diff/20001/build/linux/unbundle/zl...
build/linux/unbundle/zlib.gn:31: static_library("minizip") {
This should be a source_set.

https://codereview.chromium.org/1881263003/diff/20001/build/shim_headers.gni
File build/shim_headers.gni (right):

https://codereview.chromium.org/1881263003/diff/20001/build/shim_headers.gni#...
build/shim_headers.gni:24: outputs = []
You should be able to use something like this to avoid the loop:
  outputs = process_file_template(invoker.headers,
"$shim_headers_path/{{source_file_part}}")

[Paweł Hajdan Jr., 2016-04-15 08:00:35]

Thanks for comments, Brett! Applied.

[commit-bot: I haz the power, 2016-04-15 08:03:46]

Description was changed from

==========
unbundle: add shim_headers.gni and unbundled GN file for zlib

BUG=551343
==========

to

==========
unbundle: add shim_headers.gni and unbundled GN file for zlib

BUG=551343
R=brettw@chromium.org, dpranke@chromium.org

Committed: https://crrev.com/8c08dc447bb30eef98be3ff6d66205df611ddb9d
Cr-Commit-Position: refs/heads/master@{#387558}
==========

[commit-bot: I haz the power, 2016-04-15 08:03:47]

Patchset 3 (id:??) landed as
https://crrev.com/8c08dc447bb30eef98be3ff6d66205df611ddb9d
Cr-Commit-Position: refs/heads/master@{#387558}

[Paweł Hajdan Jr., 2016-04-15 08:04:32]

Description was changed from

==========
unbundle: add shim_headers.gni and unbundled GN file for zlib

BUG=551343
R=brettw@chromium.org, dpranke@chromium.org

Committed: https://crrev.com/8c08dc447bb30eef98be3ff6d66205df611ddb9d
Cr-Commit-Position: refs/heads/master@{#387558}
==========

to

==========
unbundle: add shim_headers.gni and unbundled GN file for zlib

BUG=551343
R=brettw@chromium.org, dpranke@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/8c08dc447bb30eef98be3ff6d662...
==========

[Paweł Hajdan Jr., 2016-04-15 08:04:33]

Committed patchset #3 (id:40001) manually as
8c08dc447bb30eef98be3ff6d66205df611ddb9d (presubmit successful).