Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6611)

Unified Diff: blimp/engine/common/blimp_pref_store.h

Issue 1881253003: Create a PrefStore in support of Blimp metrics collection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Additional test to confirm proper observer calls. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/common/blimp_pref_store.h
diff --git a/android_webview/browser/aw_pref_store.h b/blimp/engine/common/blimp_pref_store.h
similarity index 75%
copy from android_webview/browser/aw_pref_store.h
copy to blimp/engine/common/blimp_pref_store.h
index fd0a9fff8e4e68280d36560c59ca063f6235273c..12a5a059f5d21c9f83273e55840da6d55a629210 100644
--- a/android_webview/browser/aw_pref_store.h
+++ b/blimp/engine/common/blimp_pref_store.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
-#define ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
+#ifndef BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_
+#define BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_
#include <stdint.h>
@@ -15,15 +15,19 @@
#include "components/prefs/persistent_pref_store.h"
#include "components/prefs/pref_value_map.h"
+namespace blimp {
+namespace engine {
+
// A light-weight prefstore implementation that keeps preferences
// in a memory backed store. This is not a persistent prefstore -- we
// subclass the PersistentPrefStore here since it is needed by the
-// PrefService, which in turn is needed by the Autofill component.
-class AwPrefStore : public PersistentPrefStore {
+// PrefService, which in turn is needed by the metrics component.
+// Based on AwPrefStore.
+class BlimpPrefStore : public PersistentPrefStore {
public:
- AwPrefStore();
+ BlimpPrefStore();
- // Overriden from PrefStore.
+ // PrefStore implementation.
bool GetValue(const std::string& key,
const base::Value** result) const override;
void AddObserver(PrefStore::Observer* observer) override;
@@ -31,7 +35,7 @@ class AwPrefStore : public PersistentPrefStore {
bool HasObservers() const override;
bool IsInitializationComplete() const override;
- // PersistentPrefStore overrides:
+ // PersistentPrefStore implementation.
bool GetMutableValue(const std::string& key, base::Value** result) override;
void ReportValueChanged(const std::string& key, uint32_t flags) override;
void SetValue(const std::string& key,
@@ -50,7 +54,7 @@ class AwPrefStore : public PersistentPrefStore {
void ClearMutableValues() override {}
protected:
- ~AwPrefStore() override;
+ ~BlimpPrefStore() override;
private:
// Stores the preference values.
@@ -58,7 +62,10 @@ class AwPrefStore : public PersistentPrefStore {
base::ObserverList<PrefStore::Observer, true> observers_;
- DISALLOW_COPY_AND_ASSIGN(AwPrefStore);
+ DISALLOW_COPY_AND_ASSIGN(BlimpPrefStore);
};
-#endif // ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
+} // namespace engine
+} // namespace blimp
+
+#endif // BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_

Powered by Google App Engine
This is Rietveld 408576698