Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: blimp/engine/common/blimp_pref_store.h

Issue 1881253003: Create a PrefStore in support of Blimp metrics collection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Additional test to confirm proper observer calls. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_ 5 #ifndef BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_
6 #define ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_ 6 #define BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
11 11
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/observer_list.h" 14 #include "base/observer_list.h"
15 #include "components/prefs/persistent_pref_store.h" 15 #include "components/prefs/persistent_pref_store.h"
16 #include "components/prefs/pref_value_map.h" 16 #include "components/prefs/pref_value_map.h"
17 17
18 namespace blimp {
19 namespace engine {
20
18 // A light-weight prefstore implementation that keeps preferences 21 // A light-weight prefstore implementation that keeps preferences
19 // in a memory backed store. This is not a persistent prefstore -- we 22 // in a memory backed store. This is not a persistent prefstore -- we
20 // subclass the PersistentPrefStore here since it is needed by the 23 // subclass the PersistentPrefStore here since it is needed by the
21 // PrefService, which in turn is needed by the Autofill component. 24 // PrefService, which in turn is needed by the metrics component.
22 class AwPrefStore : public PersistentPrefStore { 25 // Based on AwPrefStore.
26 class BlimpPrefStore : public PersistentPrefStore {
23 public: 27 public:
24 AwPrefStore(); 28 BlimpPrefStore();
25 29
26 // Overriden from PrefStore. 30 // PrefStore implementation.
27 bool GetValue(const std::string& key, 31 bool GetValue(const std::string& key,
28 const base::Value** result) const override; 32 const base::Value** result) const override;
29 void AddObserver(PrefStore::Observer* observer) override; 33 void AddObserver(PrefStore::Observer* observer) override;
30 void RemoveObserver(PrefStore::Observer* observer) override; 34 void RemoveObserver(PrefStore::Observer* observer) override;
31 bool HasObservers() const override; 35 bool HasObservers() const override;
32 bool IsInitializationComplete() const override; 36 bool IsInitializationComplete() const override;
33 37
34 // PersistentPrefStore overrides: 38 // PersistentPrefStore implementation.
35 bool GetMutableValue(const std::string& key, base::Value** result) override; 39 bool GetMutableValue(const std::string& key, base::Value** result) override;
36 void ReportValueChanged(const std::string& key, uint32_t flags) override; 40 void ReportValueChanged(const std::string& key, uint32_t flags) override;
37 void SetValue(const std::string& key, 41 void SetValue(const std::string& key,
38 std::unique_ptr<base::Value> value, 42 std::unique_ptr<base::Value> value,
39 uint32_t flags) override; 43 uint32_t flags) override;
40 void SetValueSilently(const std::string& key, 44 void SetValueSilently(const std::string& key,
41 std::unique_ptr<base::Value> value, 45 std::unique_ptr<base::Value> value,
42 uint32_t flags) override; 46 uint32_t flags) override;
43 void RemoveValue(const std::string& key, uint32_t flags) override; 47 void RemoveValue(const std::string& key, uint32_t flags) override;
44 bool ReadOnly() const override; 48 bool ReadOnly() const override;
45 PrefReadError GetReadError() const override; 49 PrefReadError GetReadError() const override;
46 PersistentPrefStore::PrefReadError ReadPrefs() override; 50 PersistentPrefStore::PrefReadError ReadPrefs() override;
47 void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override; 51 void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override;
48 void CommitPendingWrite() override {} 52 void CommitPendingWrite() override {}
49 void SchedulePendingLossyWrites() override {} 53 void SchedulePendingLossyWrites() override {}
50 void ClearMutableValues() override {} 54 void ClearMutableValues() override {}
51 55
52 protected: 56 protected:
53 ~AwPrefStore() override; 57 ~BlimpPrefStore() override;
54 58
55 private: 59 private:
56 // Stores the preference values. 60 // Stores the preference values.
57 PrefValueMap prefs_; 61 PrefValueMap prefs_;
58 62
59 base::ObserverList<PrefStore::Observer, true> observers_; 63 base::ObserverList<PrefStore::Observer, true> observers_;
60 64
61 DISALLOW_COPY_AND_ASSIGN(AwPrefStore); 65 DISALLOW_COPY_AND_ASSIGN(BlimpPrefStore);
62 }; 66 };
63 67
64 #endif // ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_ 68 } // namespace engine
69 } // namespace blimp
70
71 #endif // BLIMP_ENGINE_COMMON_BLIMP_PREF_STORE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698