Implement Tab Detaching in Fullscreen Mode on Mac OSX

Implement Tab Detaching in Fullscreen Mode on Mac OSX

Tabs can detach from windows in fullscreen when
chrome://flags/enable-fullscreen-tab-detaching is enabled.

BUG=507942
Committed: https://crrev.com/f4e28565ff7676e13bf8bf4b3dc2965e08e9fd88
Cr-Commit-Position: refs/heads/master@{#386899}

[spqchan, 2016-04-12 18:00:28]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-04-12 18:00:29]

PTAL

[Robert Sesek, 2016-04-12 22:14:25]

LGTM w/ a nit. I can't think of a way this could be tested given the drag stuff
involved.

https://codereview.chromium.org/1881093002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1881093002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:1276: &
NSFullScreenWindowMask) == NSFullScreenWindowMask) {
nit & goes on the previous line. Break after the == instead.

[spqchan, 2016-04-12 22:55:58]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-04-12 22:55:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1881093002/#ps80001
(title: "Fix for rsesek's review")

[commit-bot: I haz the power, 2016-04-12 22:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881093002/80001

[commit-bot: I haz the power, 2016-04-13 00:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:04:37]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2016-04-13 00:44:21]

spqchan@chromium.org changed reviewers:
+ isherman@chromium.org

[spqchan, 2016-04-13 00:44:22]

+ isherman for histograms.xml OWNERS

https://codereview.chromium.org/1881093002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1881093002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:1276: &
NSFullScreenWindowMask) == NSFullScreenWindowMask) {
On 2016/04/12 22:14:25, Robert Sesek wrote:
> nit & goes on the previous line. Break after the == instead.

Done.

[Ilya Sherman, 2016-04-13 01:07:45]

histograms.xml lgtm

[spqchan, 2016-04-13 01:09:11]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-04-13 01:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1881093002/#ps100001
(title: "add to the histogram")

[commit-bot: I haz the power, 2016-04-13 01:09:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881093002/100001

[commit-bot: I haz the power, 2016-04-13 02:17:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-13 02:18:56]

Description was changed from

==========
Implement Tab Detaching in Fullscreen Mode on Mac OSX

Tabs can detach from windows in fullscreen when
chrome://flags/enable-fullscreen-tab-detaching is enabled.

BUG=507942
==========

to

==========
Implement Tab Detaching in Fullscreen Mode on Mac OSX

Tabs can detach from windows in fullscreen when
chrome://flags/enable-fullscreen-tab-detaching is enabled.

BUG=507942

Committed: https://crrev.com/f4e28565ff7676e13bf8bf4b3dc2965e08e9fd88
Cr-Commit-Position: refs/heads/master@{#386899}
==========

[commit-bot: I haz the power, 2016-04-13 02:18:57]

Patchset 6 (id:??) landed as
https://crrev.com/f4e28565ff7676e13bf8bf4b3dc2965e08e9fd88
Cr-Commit-Position: refs/heads/master@{#386899}