Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Issue 1881093002: Implement Tab Detaching in Fullscreen Mode on Mac OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add to the histogram Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_window_controller.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h" 5 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #import "base/mac/sdk_forward_declarations.h" 8 #import "base/mac/sdk_forward_declarations.h"
9 #import "chrome/browser/ui/cocoa/browser_window_layout.h" 9 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
10 #import "chrome/browser/ui/cocoa/fast_resize_view.h" 10 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 NOTIMPLEMENTED(); 248 NOTIMPLEMENTED();
249 } 249 }
250 250
251 - (TabWindowController*)detachTabsToNewWindow:(NSArray*)tabViews 251 - (TabWindowController*)detachTabsToNewWindow:(NSArray*)tabViews
252 draggedTab:(NSView*)draggedTab { 252 draggedTab:(NSView*)draggedTab {
253 // subclass must implement 253 // subclass must implement
254 NOTIMPLEMENTED(); 254 NOTIMPLEMENTED();
255 return NULL; 255 return NULL;
256 } 256 }
257 257
258 - (void)detachedWindowEnterFullscreenIfNeeded:(TabWindowController*)source {
259 // Subclasses should implement this.
260 NOTIMPLEMENTED();
261 }
262
258 - (void)insertPlaceholderForTab:(TabView*)tab frame:(NSRect)frame { 263 - (void)insertPlaceholderForTab:(TabView*)tab frame:(NSRect)frame {
259 [self showNewTabButton:NO]; 264 [self showNewTabButton:NO];
260 } 265 }
261 266
262 - (void)removePlaceholder { 267 - (void)removePlaceholder {
263 [self showNewTabButton:YES]; 268 [self showNewTabButton:YES];
264 } 269 }
265 270
266 - (BOOL)isDragSessionActive { 271 - (BOOL)isDragSessionActive {
267 NOTIMPLEMENTED(); 272 NOTIMPLEMENTED();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 NOTIMPLEMENTED(); 305 NOTIMPLEMENTED();
301 return 0; 306 return 0;
302 } 307 }
303 308
304 - (BOOL)hasLiveTabs { 309 - (BOOL)hasLiveTabs {
305 // subclass must implement 310 // subclass must implement
306 NOTIMPLEMENTED(); 311 NOTIMPLEMENTED();
307 return NO; 312 return NO;
308 } 313 }
309 314
315 - (CGFloat)menubarOffset {
316 // Subclasses should implement this.
317 NOTIMPLEMENTED();
318 return 0;
319 }
320
310 - (NSString*)activeTabTitle { 321 - (NSString*)activeTabTitle {
311 // subclass must implement 322 // subclass must implement
312 NOTIMPLEMENTED(); 323 NOTIMPLEMENTED();
313 return @""; 324 return @"";
314 } 325 }
315 326
316 - (BOOL)hasTabStrip { 327 - (BOOL)hasTabStrip {
317 // Subclasses should implement this. 328 // Subclasses should implement this.
318 NOTIMPLEMENTED(); 329 NOTIMPLEMENTED();
319 return YES; 330 return YES;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 [visualEffectView addSubview:tabStripBackgroundView_]; 391 [visualEffectView addSubview:tabStripBackgroundView_];
381 } 392 }
382 393
383 // Called when the size of the window content area has changed. Override to 394 // Called when the size of the window content area has changed. Override to
384 // position specific views. Base class implementation does nothing. 395 // position specific views. Base class implementation does nothing.
385 - (void)layoutSubviews { 396 - (void)layoutSubviews {
386 NOTIMPLEMENTED(); 397 NOTIMPLEMENTED();
387 } 398 }
388 399
389 @end 400 @end
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_window_controller.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698