Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1880873004: Port use_lld flag from gyp to gn. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, hans, Reid Kleckner, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port use_lld flag from gyp to gn. BUG=498033 Committed: https://crrev.com/52d5c52fa34e5d312e2622b7799111bb63781403 Cr-Commit-Position: refs/heads/master@{#386876}

Patch Set 1 #

Patch Set 2 : oops #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M build/toolchain/win/BUILD.gn View 1 2 6 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
4 years, 8 months ago (2016-04-12 20:56:03 UTC) #2
brettw
https://codereview.chromium.org/1880873004/diff/20001/build/toolchain/lld.gni File build/toolchain/lld.gni (right): https://codereview.chromium.org/1880873004/diff/20001/build/toolchain/lld.gni#newcode8 build/toolchain/lld.gni:8: # Set to true to use lld. Can you ...
4 years, 8 months ago (2016-04-12 21:54:51 UTC) #3
Nico
All done, thanks. (I want to try using lld on linux too "soon", but you're ...
4 years, 8 months ago (2016-04-12 22:50:47 UTC) #4
brettw
lgtm
4 years, 8 months ago (2016-04-13 00:23:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880873004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880873004/40001
4 years, 8 months ago (2016-04-13 00:24:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-13 00:30:42 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 00:31:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/52d5c52fa34e5d312e2622b7799111bb63781403
Cr-Commit-Position: refs/heads/master@{#386876}

Powered by Google App Engine
This is Rietveld 408576698