build/toolchain/lld.gni - Issue 1880873004: Port use_lld flag from gyp to gn.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/toolchain/lld.gni

Issue 1880873004: Port use_lld flag from gyp to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oops Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 # Configures if the lld linker should be used.

	6

5 declare_args() {	7 declare_args() {

6 # Mojo application directories are created within this subdirectory.	8 # Set to true to use lld.
	brettw 2016/04/12 21:54:51 Can you say what lld is? I didn't know and had to Can you say what lld is? I didn't know and had to look it up. Just like Set to true to use lld, the LLVM linker.
7 mojo_application_subdir = "Mojo Applications"	9 # Currently only has an effect on Windows.

	10 use_lld = false
	brettw 2016/04/12 21:54:51 Will you need this outside of the windows toolchai Will you need this outside of the windows toolchain setup? If not or if you're unsure, I think this declare_args should just be moved to the top of that file. We can always move it out later if we need to share it.
8 }	11 }

OLD	NEW

« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »