Move skia related files from content/common/gpu/client to gpu/skia_bindings.

Move skia related files from content/common/gpu/client to gpu/skia_bindings.

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/af87d0bbe5572dd5346dda1614567ba8309016f9
Cr-Commit-Position: refs/heads/master@{#387668}

[Peng, 2016-04-12 16:07:04]

Description was changed from

==========
Move skia related files from content/common/gpu/client to gpu/skia_bindings.

BUG=586380
==========

to

==========
Move skia related files from content/common/gpu/client to gpu/skia_bindings.

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Peng, 2016-04-12 19:20:43]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org

[Peng, 2016-04-12 19:20:44]

Hi piman, PTAL. Thanks.

[danakj, 2016-04-12 19:56:13]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-04-12 19:56:13]

https://codereview.chromium.org/1880823004/diff/20001/gpu/skia_bindings/grcon...
File gpu/skia_bindings/grcontext_for_gles2_interface.h (right):

https://codereview.chromium.org/1880823004/diff/20001/gpu/skia_bindings/grcon...
gpu/skia_bindings/grcontext_for_gles2_interface.h:24: class
GrContextForGLES2Interface {
There are a bunch of implementations of cc::ContextProvider that expose
GrContexts, but that don't use this class and basically dupliacte it inside
themselves.

Now that this isn't in content, can we switch all ContextProviders with
GrContexts to use it?

[Peng, 2016-04-13 17:44:30]

CL has been updated. PTAL.

https://codereview.chromium.org/1880823004/diff/20001/gpu/skia_bindings/grcon...
File gpu/skia_bindings/grcontext_for_gles2_interface.h (right):

https://codereview.chromium.org/1880823004/diff/20001/gpu/skia_bindings/grcon...
gpu/skia_bindings/grcontext_for_gles2_interface.h:24: class
GrContextForGLES2Interface {
On 2016/04/12 19:56:13, danakj wrote:
> There are a bunch of implementations of cc::ContextProvider that expose
> GrContexts, but that don't use this class and basically dupliacte it inside
> themselves.
> 
> Now that this isn't in content, can we switch all ContextProviders with
> GrContexts to use it?

Done.

[danakj, 2016-04-13 18:06:26]

Thanks! LGTM fwiw

https://codereview.chromium.org/1880823004/diff/40001/content/browser/android...
File content/browser/android/in_process/context_provider_in_process.cc (right):

https://codereview.chromium.org/1880823004/diff/40001/content/browser/android...
content/browser/android/in_process/context_provider_in_process.cc:152: return
gr_context_->get()->resetContext(state);
Should be gr_context_->ResetContext(state); I think?

https://codereview.chromium.org/1880823004/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1880823004/diff/40001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:144:
gr_context_->get()->resetContext(state);
gr_context_->ResetContext(state); ?

[Peng, 2016-04-13 18:17:41]

https://codereview.chromium.org/1880823004/diff/40001/content/browser/android...
File content/browser/android/in_process/context_provider_in_process.cc (right):

https://codereview.chromium.org/1880823004/diff/40001/content/browser/android...
content/browser/android/in_process/context_provider_in_process.cc:152: return
gr_context_->get()->resetContext(state);
On 2016/04/13 18:06:26, danakj wrote:
> Should be gr_context_->ResetContext(state); I think?

Done.

https://codereview.chromium.org/1880823004/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1880823004/diff/40001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:144:
gr_context_->get()->resetContext(state);
On 2016/04/13 18:06:26, danakj wrote:
> gr_context_->ResetContext(state); ?

Done.

[Peng, 2016-04-13 18:19:03]

penghuang@chromium.org changed reviewers:
+ jam@chromium.org

[Peng, 2016-04-13 18:19:05]

+jam for blimp/client/feature/compositor/blimp_context_provider.*.

Hi jam, PTAL. Thanks.

[jam, 2016-04-13 21:31:41]

On 2016/04/13 18:19:05, Peng wrote:
> +jam for blimp/client/feature/compositor/blimp_context_provider.*.
> 
> Hi jam, PTAL. Thanks.

please pick an owner from blimp/OWNERS

[piman, 2016-04-14 01:33:56]

lgtm

[Peng, 2016-04-14 14:56:44]

penghuang@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Peng, 2016-04-14 14:56:45]

+kmarshall for blimp

Hi Kevin, PATL. Thanks.

[Kevin M, 2016-04-15 17:01:19]

blimp lgtm

[Peng, 2016-04-15 18:08:20]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-04-15 18:08:21]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1880823004/#ps60001
(title: "Update")

[commit-bot: I haz the power, 2016-04-15 18:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880823004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880823004/60001

[commit-bot: I haz the power, 2016-04-15 19:11:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-15 19:12:28]

Description was changed from

==========
Move skia related files from content/common/gpu/client to gpu/skia_bindings.

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move skia related files from content/common/gpu/client to gpu/skia_bindings.

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/af87d0bbe5572dd5346dda1614567ba8309016f9
Cr-Commit-Position: refs/heads/master@{#387668}
==========

[commit-bot: I haz the power, 2016-04-15 19:12:30]

Patchset 4 (id:??) landed as
https://crrev.com/af87d0bbe5572dd5346dda1614567ba8309016f9
Cr-Commit-Position: refs/heads/master@{#387668}