Refactoring: Extract DocumentInit for capture Document construction parameter.

Refactoring: Extract DocumentInit for capture Document construction parameter.

This change replaces a set of parameters for the Document constructor
with DocumentInit class.

The motivation here is to pass a HTMLImport to the constructor.
In a coming change, passed import object will affect how the
security context of the document is decided.

For that purpose, DocumentInit encapsulates which Frame is
being used to initialize the context. The coming change will extend it
so taht HTML Imports can load external scripts.

Since DocumentInit has a default constructor, call sites where create
empty documents become cleaner.

BUG=240592
TEST=none
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154278

[Hajime Morrita, 2013-07-12 09:06:48]

Could you take a look?

[dglazkov, 2013-07-12 17:41:35]

DocumentInitializer name doesn't fit. The class doesn't initialize the Document,
it just holds the state that the document relies on. What is this beast? Perhaps
it's the elusive BrowsingContext that the HTML spec mentions?

[dglazkov, 2013-07-12 17:49:38]

This patch does things that are strikingly similar to
https://codereview.chromium.org/19002005/, but for different reasons. Maybe you
guys could consolidate?

[dominicc (has gone to gerrit), 2013-07-12 20:47:48]

On 2013/07/12 17:49:38, Dimitri Glazkov wrote:
> This patch does things that are strikingly similar to
> https://codereview.chromium.org/19002005/, but for different reasons. Maybe
you
> guys could consolidate?

Sure. Once this goes first I'll put CustomElementRegistrationContext on the
DocumentInitializer train.

[abarth-chromium, 2013-07-12 23:32:53]

lgtm

https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/Document.c...
Source/core/dom/Document.cpp:370: Document::Document(const DocumentInitializer&
initializer, DocumentClassFlags documentClasses)
DocumentInitializer -> DocumentInit ?

That name mirrors MouseEventInit and friends from DOM4 events.

https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/DocumentIn...
File Source/core/dom/DocumentInitializer.h (right):

https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/DocumentIn...
Source/core/dom/DocumentInitializer.h:46: { }
These go on separate lines.

[Hajime Morrita, 2013-07-16 02:32:35]

Thanks for the review!

On 2013/07/12 23:32:53, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/Document.cpp
> File Source/core/dom/Document.cpp (right):
> 
>
https://codereview.chromium.org/18808004/diff/3001/Source/core/dom/Document.c...
> Source/core/dom/Document.cpp:370: Document::Document(const
DocumentInitializer&
> initializer, DocumentClassFlags documentClasses)
> DocumentInitializer -> DocumentInit ?
> 
> That name mirrors MouseEventInit and friends from DOM4 events.
Makes sense. Renamed. 

> From dglazkov:
> DocumentInitializer name doesn't fit. The class doesn't initialize the
Document,
> it just holds the state that the document relies on. What is this beast?
Perhaps
> it's the elusive BrowsingContext that the HTML spec mentions?
This was kind of what I thought at first but I want this to be just a set of
parameter and not something smart.

[commit-bot: I haz the power, 2013-07-16 02:32:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/18808004/14001

[commit-bot: I haz the power, 2013-07-16 05:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/18808004/21001

[Hajime Morrita, 2013-07-16 07:45:04]

Committed patchset #4 manually as r154278 (presubmit successful).