Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1880483002: Re-add webrtc+plugins tests omitted from GN build (Closed)

Created:
4 years, 8 months ago by johnme
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mcasas
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add webrtc+plugins tests omitted from GN build https://codereview.chromium.org/1335033003 put the following 2 tests: pepper_to_video_track_adapter_unittest.cc video_track_to_pepper_adapter_unittest.cc into a new gypi section, 'content_unittests_plugin_webrtc_sources'. But it forgot to update the GN build accordingly, so PepperToVideoTrackAdapterTest & VideoTrackToPepperAdapterTest aren't currently built (or run) when using GN. This patch fixes that, putting the GN build back in sync with GYP. BUG=602256, 525817 Committed: https://crrev.com/3ff48068c9df7a6877dab8ba05b2a3f201972410 Cr-Commit-Position: refs/heads/master@{#386394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/test/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
johnme
4 years, 8 months ago (2016-04-11 13:48:46 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 8 months ago (2016-04-11 15:11:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880483002/1
4 years, 8 months ago (2016-04-11 15:11:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 15:51:16 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 15:52:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ff48068c9df7a6877dab8ba05b2a3f201972410
Cr-Commit-Position: refs/heads/master@{#386394}

Powered by Google App Engine
This is Rietveld 408576698