Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1335033003: Reland: content_{renderer,tests}.gypi cleanup of plugin+webrtc sources (Closed)

Created:
5 years, 3 months ago by mcasas
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: content_{renderer,tests}.gypi cleanup of plugin+webrtc sources Relanding after adding the missing BUILD.gn configuration. TBR=mark@chromium.org, rationale: this patch is equivalent to the already LGTMd plus some stale .gyp code removal. Original description --------------------------------------------------- content_{renderer,tests}.gypi cleanup of plugin+webrtc sources Moving around some files after renaming made more evident what they do. BUG=525817, 530330 Committed: https://crrev.com/fc3c2df218caee93a913612a6ad6ef84f6169d0c Cr-Commit-Position: refs/heads/master@{#348232} Committed: https://crrev.com/6029f8d1cd9c3217d4640abb9071a3e880f9ca66 Cr-Commit-Position: refs/heads/master@{#348468}

Patch Set 1 : Verbatim http://crrev.com/1327353002 #

Patch Set 2 : Sort out content/test/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M content/content_renderer.gypi View 8 chunks +20 lines, -25 lines 0 comments Download
M content/content_tests.gypi View 6 chunks +9 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335033003/20001
5 years, 3 months ago (2015-09-11 19:07:53 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-11 19:07:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335033003/20001
5 years, 3 months ago (2015-09-11 19:12:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 19:52:41 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6029f8d1cd9c3217d4640abb9071a3e880f9ca66 Cr-Commit-Position: refs/heads/master@{#348468}
5 years, 3 months ago (2015-09-11 19:53:40 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:25:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6029f8d1cd9c3217d4640abb9071a3e880f9ca66
Cr-Commit-Position: refs/heads/master@{#348468}

Powered by Google App Engine
This is Rietveld 408576698