Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1880473003: Make ModuleSystem have a const view of ResourceBundleSourceMap. (Closed)

Created:
4 years, 8 months ago by lazyboy
Modified:
4 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ModuleSystem have a const view of ResourceBundleSourceMap. I am working on creating ModuleSystem for Service Workers (http://crrev.com/1714783002), where it is important to emphasize the fact that ModuleSystem has a "read only" view to SourceMap and can access the SourceMap items from threads other than the main thread. BUG=602442 Committed: https://crrev.com/ce33396f3f4f6bd09dde6984c9564bf654c3bef1 Cr-Commit-Position: refs/heads/master@{#386742}

Patch Set 1 #

Patch Set 2 : fix compile #

Total comments: 4

Patch Set 3 : remove double lookups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M extensions/renderer/module_system.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.h View 2 chunks +4 lines, -7 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.cc View 1 2 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lazyboy
4 years, 8 months ago (2016-04-12 00:18:39 UTC) #3
Devlin
lgtm https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/module_system_test.cc File extensions/renderer/module_system_test.cc (right): https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/module_system_test.cc#newcode109 extensions/renderer/module_system_test.cc:109: if (source_map_.count(name) == 0) Unrelated to this patch, ...
4 years, 8 months ago (2016-04-12 17:01:25 UTC) #4
lazyboy
Comments addressed in patch set #3 https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/module_system_test.cc File extensions/renderer/module_system_test.cc (right): https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/module_system_test.cc#newcode109 extensions/renderer/module_system_test.cc:109: if (source_map_.count(name) == ...
4 years, 8 months ago (2016-04-12 17:29:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880473003/40001
4 years, 8 months ago (2016-04-12 18:15:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-12 18:22:16 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:24:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce33396f3f4f6bd09dde6984c9564bf654c3bef1
Cr-Commit-Position: refs/heads/master@{#386742}

Powered by Google App Engine
This is Rietveld 408576698