Make ModuleSystem have a const view of ResourceBundleSourceMap.

Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442
Committed: https://crrev.com/ce33396f3f4f6bd09dde6984c9564bf654c3bef1
Cr-Commit-Position: refs/heads/master@{#386742}

[lazyboy, 2016-04-11 21:19:20]

Description was changed from

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=None
==========

to

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442
==========

[lazyboy, 2016-04-12 00:18:38]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-04-12 17:01:25]

lgtm

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/mod...
File extensions/renderer/module_system_test.cc (right):

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/mod...
extensions/renderer/module_system_test.cc:109: if (source_map_.count(name) == 0)
Unrelated to this patch, but this is a double look-up.  Can we make this just
use find() from the start?

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/res...
File extensions/renderer/resource_bundle_source_map.cc (right):

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/res...
extensions/renderer/resource_bundle_source_map.cc:42: if (!Contains(name)) {
nit: another double-lookup.

[lazyboy, 2016-04-12 17:29:28]

Comments addressed in patch set #3

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/mod...
File extensions/renderer/module_system_test.cc (right):

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/mod...
extensions/renderer/module_system_test.cc:109: if (source_map_.count(name) == 0)
On 2016/04/12 17:01:25, Devlin wrote:
> Unrelated to this patch, but this is a double look-up.  Can we make this just
> use find() from the start?

Good catch, thank you.
Done.

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/res...
File extensions/renderer/resource_bundle_source_map.cc (right):

https://codereview.chromium.org/1880473003/diff/20001/extensions/renderer/res...
extensions/renderer/resource_bundle_source_map.cc:42: if (!Contains(name)) {
On 2016/04/12 17:01:25, Devlin wrote:
> nit: another double-lookup.

Done.

[lazyboy, 2016-04-12 18:15:07]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-04-12 18:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1880473003/#ps40001
(title: "remove double lookups")

[commit-bot: I haz the power, 2016-04-12 18:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880473003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880473003/40001

[commit-bot: I haz the power, 2016-04-12 18:22:15]

Description was changed from

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442
==========

to

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442
==========

[commit-bot: I haz the power, 2016-04-12 18:22:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 18:24:04]

Description was changed from

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442
==========

to

==========
Make ModuleSystem have a const view of ResourceBundleSourceMap.

I am working on creating ModuleSystem for Service Workers
(http://crrev.com/1714783002), where it is important to emphasize the
fact that ModuleSystem has a "read only" view to SourceMap and can
access the SourceMap items from threads other than the main thread.

BUG=602442

Committed: https://crrev.com/ce33396f3f4f6bd09dde6984c9564bf654c3bef1
Cr-Commit-Position: refs/heads/master@{#386742}
==========

[commit-bot: I haz the power, 2016-04-12 18:24:05]

Patchset 3 (id:??) landed as
https://crrev.com/ce33396f3f4f6bd09dde6984c9564bf654c3bef1
Cr-Commit-Position: refs/heads/master@{#386742}