Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: extensions/renderer/module_system_test.cc

Issue 1880473003: Make ModuleSystem have a const view of ResourceBundleSourceMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove double lookups Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/resource_bundle_source_map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system_test.cc
diff --git a/extensions/renderer/module_system_test.cc b/extensions/renderer/module_system_test.cc
index 06a4d5590460f24d3ec457e47dbc07aa5772bf63..b987ee7c9d4eff434e5d8d4d2ce0e5b969d8fdb7 100644
--- a/extensions/renderer/module_system_test.cc
+++ b/extensions/renderer/module_system_test.cc
@@ -105,13 +105,14 @@ class ModuleSystemTestEnvironment::StringSourceMap
~StringSourceMap() override {}
v8::Local<v8::Value> GetSource(v8::Isolate* isolate,
- const std::string& name) override {
- if (source_map_.count(name) == 0)
+ const std::string& name) const override {
+ const auto& source_map_iter = source_map_.find(name);
+ if (source_map_iter == source_map_.end())
return v8::Undefined(isolate);
- return v8::String::NewFromUtf8(isolate, source_map_[name].c_str());
+ return v8::String::NewFromUtf8(isolate, source_map_iter->second.c_str());
}
- bool Contains(const std::string& name) override {
+ bool Contains(const std::string& name) const override {
return source_map_.count(name);
}
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/resource_bundle_source_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698