Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880423003: [build] New VS 2013 toolchain with setenv.*.json (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, brucedawson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] New VS 2013 toolchain with setenv.*.json Port https://codereview.chromium.org/1886493002 BUG=chromium:603011, chromium:603131 LOG=n TBR=jochen@chromium.org Committed: https://crrev.com/8f8dd7150f39f9067f4f7493a32931b296e6d9b6 Cr-Commit-Position: refs/heads/master@{#35470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
TBR
4 years, 8 months ago (2016-04-14 07:37:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880423003/1
4 years, 8 months ago (2016-04-14 07:38:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 07:58:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:59:14 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f8dd7150f39f9067f4f7493a32931b296e6d9b6
Cr-Commit-Position: refs/heads/master@{#35470}

Powered by Google App Engine
This is Rietveld 408576698