Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1886493002: New VS 2013 toolchain with setenv.*.json (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 8 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New VS 2013 toolchain with setenv.*.json VS 2015 is used for Chromium builds, but having VS 2013 available is useful, in particular for SDK bots for nacl. This changes the VS 2013 tool set to one that has setenv.*.json files that were made necessary by crrev.com/1805173002 so that VS 2013 can still be used. BUG=495204 Committed: https://crrev.com/b10de5ecc2966315ace053a8f8f6054844324d3a Cr-Commit-Position: refs/heads/master@{#387032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bradnelson
lgtm
4 years, 8 months ago (2016-04-13 17:33:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886493002/1
4 years, 8 months ago (2016-04-13 17:33:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 18:19:03 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:20:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b10de5ecc2966315ace053a8f8f6054844324d3a
Cr-Commit-Position: refs/heads/master@{#387032}

Powered by Google App Engine
This is Rietveld 408576698