Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1880413002: Revert of [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. (patchset #3 id:40001 of https://codereview.chromium.org/1881003002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/1617503003 Original issue's description: > [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. > > Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers. > > Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4 > Cr-Commit-Position: refs/heads/master@{#35433} TBR=bmeurer@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/29ae208362721909b18d58eda97391676aa0d646 Cr-Commit-Position: refs/heads/master@{#35444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -136 lines) Patch
M src/code-factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -28 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.
4 years, 8 months ago (2016-04-13 12:10:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880413002/1
4 years, 8 months ago (2016-04-13 12:10:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 12:10:49 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 12:12:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29ae208362721909b18d58eda97391676aa0d646
Cr-Commit-Position: refs/heads/master@{#35444}

Powered by Google App Engine
This is Rietveld 408576698