Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/compiler/code-stub-assembler.cc

Issue 1880413002: Revert of [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/code-stub-assembler.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-stub-assembler.cc
diff --git a/src/compiler/code-stub-assembler.cc b/src/compiler/code-stub-assembler.cc
index 1da2fdd679186f5e237325e2094c90ee39f2f649..425f6bee7d5969fedb77a0ea8f47c38b1b7b4a80 100644
--- a/src/compiler/code-stub-assembler.cc
+++ b/src/compiler/code-stub-assembler.cc
@@ -879,41 +879,6 @@
var_result.Bind(result);
}
Goto(&if_join);
- Bind(&if_join);
- return var_result.value();
-}
-
-Node* CodeStubAssembler::ChangeUint32ToTagged(Node* value) {
- Label if_overflow(this, Label::kDeferred), if_not_overflow(this),
- if_join(this);
- Variable var_result(this, MachineRepresentation::kTagged);
- // If {value} > 2^31 - 1, we need to store it in a HeapNumber.
- Branch(Int32LessThan(value, Int32Constant(0)), &if_overflow,
- &if_not_overflow);
- Bind(&if_not_overflow);
- {
- if (raw_assembler_->machine()->Is64()) {
- var_result.Bind(SmiTag(ChangeUint32ToUint64(value)));
- } else {
- // If tagging {value} results in an overflow, we need to use a HeapNumber
- // to represent it.
- Node* pair = Int32AddWithOverflow(value, value);
- Node* overflow = Projection(1, pair);
- GotoIf(overflow, &if_overflow);
-
- Node* result = Projection(0, pair);
- var_result.Bind(result);
- }
- }
- Goto(&if_join);
-
- Bind(&if_overflow);
- {
- Node* float64_value = ChangeUint32ToFloat64(value);
- var_result.Bind(AllocateHeapNumberWithValue(float64_value));
- }
- Goto(&if_join);
-
Bind(&if_join);
return var_result.value();
}
« no previous file with comments | « src/compiler/code-stub-assembler.h ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698