Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1880393005: [css-grid] Fix alignment with content distribution (Closed)

Created:
4 years, 8 months ago by Manuel Rego
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix alignment with content distribution We were only subtracting the distribution offset for items spanning several tracks, but not for items in a single cell. We should actually subtract the offset in that situation too, the same that we do for the grid gaps. Created new test and renamed the old one as it was only testing items spanning several cells. BUG=602670 TEST=fast/css-grid-layout/grid-content-alignment-and-self-alignment.html Committed: https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0 Cr-Commit-Position: refs/heads/master@{#387888}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Messages

Total messages: 14 (6 generated)
Manuel Rego
4 years, 8 months ago (2016-04-14 07:11:17 UTC) #2
cbiesinger
lgtm
4 years, 8 months ago (2016-04-15 21:55:56 UTC) #3
cbiesinger
https://codereview.chromium.org/1880393005/diff/1/third_party/WebKit/Source/core/layout/LayoutGrid.cpp File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1880393005/diff/1/third_party/WebKit/Source/core/layout/LayoutGrid.cpp#newcode1970 third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1970: // m_rowPositions include distribution offset (becuase of content alignment) ...
4 years, 8 months ago (2016-04-15 21:56:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880393005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880393005/20001
4 years, 8 months ago (2016-04-18 07:09:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/55264)
4 years, 8 months ago (2016-04-18 09:09:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880393005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880393005/20001
4 years, 8 months ago (2016-04-18 09:29:37 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 11:19:12 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:20:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0
Cr-Commit-Position: refs/heads/master@{#387888}

Powered by Google App Engine
This is Rietveld 408576698