third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h - Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ugh. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

index 9fc45a218dcc6db9c14dc2edd987936c7c59cbef..7603c4940414eba0d0f1887a27a5220b3f2bdd4d 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

@@ -9,7 +9,7 @@

#include "bindings/core/v8/SerializedScriptValue.h"

#include "bindings/modules/v8/UnionTypesModules.h"

#include "modules/ModulesExport.h"

-#include "modules/credentialmanager/Credential.h"

+#include "modules/credentialmanager/SiteBoundCredential.h"

#include "platform/heap/Handle.h"

#include "platform/network/EncodedFormData.h"

#include "platform/weborigin/KURL.h"

@@ -24,7 +24,7 @@ class WebPasswordCredential;

using CredentialPostBodyType = FormDataOrURLSearchParams;

-class MODULES_EXPORT PasswordCredential final : public Credential {

+class MODULES_EXPORT PasswordCredential final : public SiteBoundCredential {

DEFINE_WRAPPERTYPEINFO();

public:

static PasswordCredential* create(const PasswordCredentialData&, ExceptionState&);