third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp - Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ugh. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

index 98392e0a11b41c32eafc6cafa6f047ecb72735c8..913a2b90519f403d5622fbfc95c93276d4ccf3ab 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

@@ -105,14 +105,14 @@ PasswordCredential* PasswordCredential::create(HTMLFormElement* form, ExceptionS

}

PasswordCredential::PasswordCredential(WebPasswordCredential* webPasswordCredential)

- : Credential(webPasswordCredential->getPlatformCredential())

+ : SiteBoundCredential(webPasswordCredential->getPlatformCredential())

, m_idName("username")

, m_passwordName("password")

{

}

PasswordCredential::PasswordCredential(const String& id, const String& password, const String& name, const KURL& icon)

- : Credential(PlatformPasswordCredential::create(id, password, name, icon))

+ : SiteBoundCredential(PlatformPasswordCredential::create(id, password, name, icon))

, m_idName("username")

, m_passwordName("password")

{

@@ -167,7 +167,7 @@ const String& PasswordCredential::password() const

DEFINE_TRACE(PasswordCredential)

{

- Credential::trace(visitor);

+ SiteBoundCredential::trace(visitor);

visitor->trace(m_additionalData);

}