Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1880383003:
[build] Port latest vs_toolchain script. (Closed)
|
Created:
4 years, 8 months ago by Michael Achenbach Modified:
4 years, 8 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Port latest vs_toolchain script.
BUG=chromium:603011, chromium:603131
LOG=n
Committed: https://crrev.com/0da17134e2f492e7593ca6e62b554125fb923df7
Cr-Commit-Position: refs/heads/master@{#35452}
Patch Set 1 #Patch Set 2 : V8-specific gyp location #Patch Set 3 : pythonpath #Patch Set 4 : Copyright #
Total comments: 2
Messages
Total messages: 33 (14 generated)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880383003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/67)
Description was changed from ========== [build] Port latest vs_toolchain script. BUG= ========== to ========== [build] Port latest vs_toolchain script. BUG=603011,603131 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880383003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880383003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880383003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880383003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13574)
Description was changed from ========== [build] Port latest vs_toolchain script. BUG=603011,603131 ========== to ========== [build] Port latest vs_toolchain script. BUG=chromium:603011,chromium:603131 LOG=n ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880383003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880383003/60001
machenbach@chromium.org changed reviewers: + jochen@chromium.org, thakis@chromium.org
PTAL. Copied over the latest version of this script from chromium with minor adjustments. https://codereview.chromium.org/1880383003/diff/60001/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/1880383003/diff/60001/build/vs_toolchain.py#n... build/vs_toolchain.py:19: sys.path.insert(1, os.path.join(chrome_src, 'tools')) Adjusted some v8-specific paths. https://codereview.chromium.org/1880383003/diff/60001/build/vs_toolchain.py#n... build/vs_toolchain.py:27: # Use MSVS2013 as the default toolchain. Keeping the 2013 default for now.
lgtm stamp Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to re-push the 2013 toolchain with that setenv json file?
On 2016/04/13 15:12:45, Nico wrote: > lgtm stamp > > Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to > re-push the 2013 toolchain with that setenv json file? We'll also switch soon, tracking here: https://bugs.chromium.org/p/chromium/issues/detail?id=603131 But this update was mainly for getting win-clang to work. Didn't want to switch too many things at the same time.
On 2016/04/13 at 15:12:45, thakis wrote: > lgtm stamp > > Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to re-push the 2013 toolchain with that setenv json file? Can 2013 actually still (correctly) compile v8, since we started using more c++11 features?
On 2016/04/13 15:15:00, jochen - slow wrote: > On 2016/04/13 at 15:12:45, thakis wrote: > > lgtm stamp > > > > Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to > re-push the 2013 toolchain with that setenv json file? > > Can 2013 actually still (correctly) compile v8, since we started using more > c++11 features? Hmm, well, we're using it right now.
On 2016/04/13 15:15:00, jochen - slow wrote: > On 2016/04/13 at 15:12:45, thakis wrote: > > lgtm stamp > > > > Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to > re-push the 2013 toolchain with that setenv json file? > > Can 2013 actually still (correctly) compile v8, since we started using more > c++11 features? all your standalone bots are green, so yes, right?
On 2016/04/13 at 15:16:34, thakis wrote: > On 2016/04/13 15:15:00, jochen - slow wrote: > > On 2016/04/13 at 15:12:45, thakis wrote: > > > lgtm stamp > > > > > > Bruce, v8 is going to stay on 2013 for now too. Did you have an opportunity to > > re-push the 2013 toolchain with that setenv json file? > > > > Can 2013 actually still (correctly) compile v8, since we started using more > > c++11 features? > > all your standalone bots are green, so yes, right? Mumble mumble test coverage mumble But since you'll switch soon anyways, lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880383003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880383003/60001
Message was sent while issue was closed.
Description was changed from ========== [build] Port latest vs_toolchain script. BUG=chromium:603011,chromium:603131 LOG=n ========== to ========== [build] Port latest vs_toolchain script. BUG=chromium:603011,chromium:603131 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [build] Port latest vs_toolchain script. BUG=chromium:603011,chromium:603131 LOG=n ========== to ========== [build] Port latest vs_toolchain script. BUG=chromium:603011,chromium:603131 LOG=n Committed: https://crrev.com/0da17134e2f492e7593ca6e62b554125fb923df7 Cr-Commit-Position: refs/heads/master@{#35452} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0da17134e2f492e7593ca6e62b554125fb923df7 Cr-Commit-Position: refs/heads/master@{#35452}
Message was sent while issue was closed.
On 2016/04/13 16:51:56, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as > https://crrev.com/0da17134e2f492e7593ca6e62b554125fb923df7 > Cr-Commit-Position: refs/heads/master@{#35452} Maybe too late/not-relevant, but I did create a new VS 2013 toolchain with the setenv.*.json file - it's up for review at https://codereview.chromium.org/1886493002. It was requested by bradnelson@ so that they weren't forced to move to VS 2015 before they were ready. FWIW. |
