Index: components/crash/content/tools/generate_breakpad_symbols.py |
diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py |
index e91a8c44252927495164482ed690b09b36793c02..b4c3b48a7002ed0e3ff0edadc15e9c6683659e9b 100755 |
--- a/components/crash/content/tools/generate_breakpad_symbols.py |
+++ b/components/crash/content/tools/generate_breakpad_symbols.py |
@@ -146,7 +146,7 @@ def mkdir_p(path): |
def GetBinaryInfoFromHeaderInfo(header_info): |
"""Given a standard symbol header information line, returns BINARY_INFO.""" |
# header info is of the form "MODULE $PLATFORM $ARCH $HASH $BINARY" |
jochen (gone - plz use gerrit)
2016/04/14 13:30:09
is the comment still up to date? Can you explain w
David Yen
2016/04/14 16:46:06
I was confused about this too, the max splits is 1
|
- info_split = header_info.strip().split(' ', 5) |
+ info_split = header_info.strip().split(' ', 4) |
if len(info_split) != 5 or info_split[0] != 'MODULE': |
jochen (gone - plz use gerrit)
2016/04/14 13:30:09
the first condition is now basically always true,
David Yen
2016/04/14 16:46:06
see explanation above
|
return None |
return BINARY_INFO(*info_split[1:]) |