Use is_valid_dump to check for valid dumps in telemetry exceptions.

components/crash/content/tools/generate_breakpad_symbols.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to generate symbols for a binary suitable for breakpad.
 
 Currently, the tool only supports Linux, Android, and Mac. Support for other
 platforms is planned.
 """
@@ skipping 127 matching lines @@
   try:
     os.makedirs(path)
   except OSError as e:
     if e.errno == errno.EEXIST and os.path.isdir(path):
       pass
     else: raise
 
 
 def GetBinaryInfoFromHeaderInfo(header_info):
   """Given a standard symbol header information line, returns BINARY_INFO."""
   # header info is of the form "MODULE $PLATFORM $ARCH $HASH $BINARY"

[jochen (gone - plz use gerrit), 2016/04/14 13:30:09]

is the comment still up to date? Can you explain why it would only split it in
four?

[David Yen, 2016/04/14 16:46:06]

I was confused about this too, the max splits is 1 less than the max number of
results: so "1 2" with with 1 split is [1], [2], "1 2 3 4 5" with 4 splits is
[1], [2], [3], [4], [5]. In other words, it's the number of commas.

-  info_split = header_info.strip().split(' ', 5)
+  info_split = header_info.strip().split(' ', 4)
   if len(info_split) != 5 or info_split[0] != 'MODULE':

[jochen (gone - plz use gerrit), 2016/04/14 13:30:09]

the first condition is now basically always true, no?

[David Yen, 2016/04/14 16:46:06]

see explanation above

     return None
   return BINARY_INFO(*info_split[1:])
 
 
 def GenerateSymbols(options, binaries):
   """Dumps the symbols of binary and places them in the given directory."""
 
   queue = Queue.Queue()
   print_lock = threading.Lock()
 
@@ skipping 127 matching lines @@
     binaries |= new_deps
     queue.extend(list(new_deps))
 
   GenerateSymbols(options, binaries)
 
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main())