Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: ui/events/BUILD.gn

Issue 1880313004: Remove X11 deps from //ui/events:events_base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device_refactor
Patch Set: Fix bad rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/events/devices/x11/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/BUILD.gn
diff --git a/ui/events/BUILD.gn b/ui/events/BUILD.gn
index ed1ba0acb7ee91799ede74ad80b9668199151788..d561f60a12868ed7e72fa0a93e6e57ee77acffc1 100644
--- a/ui/events/BUILD.gn
+++ b/ui/events/BUILD.gn
@@ -77,28 +77,8 @@ component("events_base") {
"//ui/gfx/geometry",
]
- # TODO(kylechar): move keycodes/ files into own component and x/ files into
- # ui/events/x component
- if (use_x11 || ozone_platform_x11) {
- configs += [ "//build/config/linux:x11" ]
-
- sources += [
- "keycodes/keyboard_code_conversion_x.cc",
- "keycodes/keyboard_code_conversion_x.h",
- "keycodes/keysym_to_unicode.cc",
- "keycodes/keysym_to_unicode.h",
- ]
-
- deps += [ "//ui/gfx/x" ]
- }
-
- if (use_x11 || ozone_platform_x11 || use_xkbcommon) {
- sources += [
- "keycodes/keyboard_code_conversion_xkb.cc",
- "keycodes/keyboard_code_conversion_xkb.h",
- "keycodes/scoped_xkb.h",
- "keycodes/xkb_keysym.h",
- ]
+ if (use_x11) {
+ public_deps += [ "//ui/events/keycodes:x11" ]
}
if (!is_ios) {
@@ -166,14 +146,11 @@ component("events") {
deps += [
"//ui/events/devices",
"//ui/events/devices/x11",
+ "//ui/events/x",
"//ui/gfx/x",
]
}
- if (use_x11 || ozone_platform_x11) {
- deps += [ "//ui/events/x" ]
- }
-
if (!is_chromeos && is_linux) {
sources += [
"linux/text_edit_command_auralinux.cc",
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/events/devices/x11/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698