third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html - Issue 1880283006: ColumnBalancer: Count line box overflow as space shortage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html

Issue 1880283006: ColumnBalancer: Count line box overflow as space shortage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html b/third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html

new file mode 100644

index 0000000000000000000000000000000000000000..25d8e191c9d0f314ffc7d3e19e249a3e9f6afad0

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html

@@ -0,0 +1,19 @@

+<!DOCTYPE html>

+<script src="../../resources/ahem.js"></script>

+<p>There should be 5 short vertical lines below.</p>

+<div style="columns:6; column-gap:2px; column-rule:2px solid; width:250px; font:20px/14px Ahem;">

+ <!-- We set a 20px tall font and a line height of 14px, so that text will overflow their line

+ boxes. We thus get 6px of overflow, and the text will overflow the line equally above and

+ below the line box, so that we have 3px on each side. The 3px of overflow below the lines

+ needs to be counted as space shortage by the column balancer, or it will erroneously

+ stretch the columns so much that two lines of text will fit in each column, leaving empty

+ columns at the end. Which would be silly, given that we have 6 lines of equal height and 6

+ columns. -->

+  <br>

+</div>