third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html - Issue 1880283006: ColumnBalancer: Count line box overflow as space shortage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow.html

Issue 1880283006: ColumnBalancer: Count line box overflow as space shortage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/ahem.js"></script>

	3 <p>There should be 5 short vertical lines below.</p>

	4 <div style="columns:6; column-gap:2px; column-rule:2px solid; width:250px; font: 20px/14px Ahem;">

	5 <!-- We set a 20px tall font and a line height of 14px, so that text will ov erflow their line

	6 boxes. We thus get 6px of overflow, and the text will overflow the line equally above and

	7 below the line box, so that we have 3px on each side. The 3px of overfl ow below the lines

	8 needs to be counted as space shortage by the column balancer, or it wil l erroneously

	9 stretch the columns so much that two lines of text will fit in each col umn, leaving empty

	10 columns at the end. Which would be silly, given that we have 6 lines of equal height and 6

	11 columns. -->

	12

	13  <br>

	14  <br>

	15  <br>

	16  <br>

	17  <br>

	18  <br>

	19 </div>

OLD	NEW