ColumnBalancer: Count line box overflow as space shortage.

ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487
Committed: https://crrev.com/89af9020b871e6b059acd480b897dd4d8fa5019b
Cr-Commit-Position: refs/heads/master@{#387072}

[mstensho (USE GERRIT), 2016-04-13 13:34:10]

Description was changed from

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.
==========

to

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487
==========

[mstensho (USE GERRIT), 2016-04-13 16:41:50]

mstensho@opera.com changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-04-13 19:44:39]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-04-13 19:44:40]

lgtm

https://codereview.chromium.org/1880283006/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html
(right):

https://codereview.chromium.org/1880283006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/multicol/balance-line-overflow-expected.html:4:
<div style="float:left; width:40px; height:100%; border-right:2px solid;"></div>
I'm impressed that these floats get the rendering exactly right. Awesome it
does, though :)

[commit-bot: I haz the power, 2016-04-13 19:45:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880283006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880283006/1

[commit-bot: I haz the power, 2016-04-13 19:55:00]

Description was changed from

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487
==========

to

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487
==========

[commit-bot: I haz the power, 2016-04-13 19:55:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 19:56:02]

Description was changed from

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487
==========

to

==========
ColumnBalancer: Count line box overflow as space shortage.

Even if the line itself fits nicely inside a column, it may have bottom
overflow that crosses a column boundary. This needs to be counted as space
shortage, or the column balancer might end up over-stretching the columns.

LayoutTests/ietestcenter/css3/multicolumn/column-width-applies-to-007.htm
now passes when opened manually. This used to fail, at least on my machine.

BUG=543487

Committed: https://crrev.com/89af9020b871e6b059acd480b897dd4d8fa5019b
Cr-Commit-Position: refs/heads/master@{#387072}
==========

[commit-bot: I haz the power, 2016-04-13 19:56:04]

Patchset 1 (id:??) landed as
https://crrev.com/89af9020b871e6b059acd480b897dd4d8fa5019b
Cr-Commit-Position: refs/heads/master@{#387072}