Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1880283004: [Media Router WebUI] Put sink list in conditional template. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Put sink list in conditional template. When the dialog is initially loaded, the sink list is always empty, so there is no need to immediately stamp the elements. This reduces the number of elements on initial load from 116 to 112. BUG=549289 Committed: https://crrev.com/63bc29f4bb9aa9dc8620451155d53f967ca68bdd Cr-Commit-Position: refs/heads/master@{#387143}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Messages

Total messages: 13 (8 generated)
apacible
PTAL, thanks!
4 years, 8 months ago (2016-04-13 16:33:50 UTC) #5
mark a. foltz
lgtm
4 years, 8 months ago (2016-04-13 19:55:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880283004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880283004/60001
4 years, 8 months ago (2016-04-13 23:07:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-04-13 23:14:59 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:17:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63bc29f4bb9aa9dc8620451155d53f967ca68bdd
Cr-Commit-Position: refs/heads/master@{#387143}

Powered by Google App Engine
This is Rietveld 408576698