chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js - Issue 1880283004: [Media Router WebUI] Put sink list in conditional template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

Issue 1880283004: [Media Router WebUI] Put sink list in conditional template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('k') | chrome/test/data/webui/media_router/media_router_container_filter_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

diff --git a/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js b/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

index 93b74981c1f0c4a28270cae795f48475d72cbaab..9500f668ad7deec2e3f2608e55119923b6da6254 100644

--- a/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

+++ b/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js

@@ -297,7 +297,8 @@ cr.define('media_router_container_cast_mode_list', function() {

setTimeout(function() {

var sinkList =

- container.$['sink-list'].querySelectorAll('paper-item');

+ container.shadowRoot.getElementById('sink-list')

+ .querySelectorAll('paper-item');

// The sink list is empty because none of the sinks in fakeSinkList

// is compatible with cast mode 0.

@@ -307,7 +308,8 @@ cr.define('media_router_container_cast_mode_list', function() {

setTimeout(function() {

var sinkList =

- container.$['sink-list'].querySelectorAll('paper-item');

+ container.shadowRoot.getElementById('sink-list')

+ .querySelectorAll('paper-item');

assertEquals(3, sinkList.length);

done();

});

@@ -339,7 +341,8 @@ cr.define('media_router_container_cast_mode_list', function() {

setTimeout(function() {

var sinkList =

- container.$['sink-list'].querySelectorAll('paper-item');

+ container.shadowRoot.getElementById('sink-list')

+ .querySelectorAll('paper-item');

// Since we haven't selected a cast mode, we don't filter sinks.

assertEquals(3, sinkList.length);

@@ -357,7 +360,8 @@ cr.define('media_router_container_cast_mode_list', function() {

setTimeout(function() {

var sinkList =

- container.$['sink-list'].querySelectorAll('paper-item');

+ container.shadowRoot.getElementById('sink-list')

+ .querySelectorAll('paper-item');

// newSinks[0] got filtered out since it is not compatible with

// cast mode 1.

@@ -382,7 +386,8 @@ cr.define('media_router_container_cast_mode_list', function() {

assertEquals(fakeCastModeList[1].type,

container.shownCastModeValue_);

var sinkList =

- container.$['sink-list'].querySelectorAll('paper-item');

+ container.shadowRoot.getElementById('sink-list')

+ .querySelectorAll('paper-item');

assertEquals(0, sinkList.length);

done();

});