Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1880263002: [sqlite] Backport icuCaseFunc16 patch from SQLite. (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[sqlite] Backport icuCaseFunc16 patch from SQLite. Original Chromium CL at https://codereview.chromium.org/1704103002 "Fix sqlite3's handling of casemapping result 3 times as long as input" SQLite interpretation at http://www.sqlite.org/src/info/b8dc1b9f5d413000 "Fix a potential buffer overflow in the ICU upper() function." The upstream change handles an empty input string while the original Chromium CL (mine) does not. (bug 594478). This is a copy of the CL by shess at https://codereview.chromium.org/1746453002/ . BUG=586079, 594478 TEST=https://jsfiddle.net/ym2nuaj2/3/ (from bug 594478 comment 1) TBR=shess@chromium.org Review URL: https://codereview.chromium.org/1866753005 Cr-Commit-Position: refs/heads/master@{#385621} (cherry picked from commit a8f7233f06c51fcec01dbacf92dfe7c1ec14c25f) Committed: https://chromium.googlesource.com/chromium/src/+/e6f2e355e6cb7dde3b1e913cd0bc732ba694ef95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -171 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.c View 2 chunks +21 lines, -32 lines 0 comments Download
A third_party/sqlite/patches/0013-backport-Fix-buffer-overrun-in-ICU-extension-s-casem.patch View 1 chunk +119 lines, -0 lines 0 comments Download
D third_party/sqlite/patches/0013-icu-Fix-buffer-overflow-when-case-mapping-expands-to.patch View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/sqlite/src/ext/icu/icu.c View 2 chunks +21 lines, -32 lines 0 comments Download
M third_party/sqlite/src/test/icu.test View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jungshik at Google
4 years, 8 months ago (2016-04-12 20:52:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6f2e355e6cb7dde3b1e913cd0bc732ba694ef95.

Powered by Google App Engine
This is Rietveld 408576698