Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1866753005: [sqlite] Backport icuCaseFunc16 patch from SQLite. (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
CC:
tinazh, chromium-reviews, chromium-apps-reviews_chromium.org, jshin+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Backport icuCaseFunc16 patch from SQLite. Original Chromium CL at https://codereview.chromium.org/1704103002 "Fix sqlite3's handling of casemapping result 3 times as long as input" SQLite interpretation at http://www.sqlite.org/src/info/b8dc1b9f5d413000 "Fix a potential buffer overflow in the ICU upper() function." This is a copy of the CL by shess at https://codereview.chromium.org/1746453002/ . BUG=586079, 594478 TEST=https://jsfiddle.net/ym2nuaj2/3/ (from bug 594478 comment 1) TBR=shess@chromium.org Committed: https://crrev.com/a8f7233f06c51fcec01dbacf92dfe7c1ec14c25f Cr-Commit-Position: refs/heads/master@{#385621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -171 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.c View 2 chunks +21 lines, -32 lines 0 comments Download
A third_party/sqlite/patches/0013-backport-Fix-buffer-overrun-in-ICU-extension-s-casem.patch View 1 chunk +119 lines, -0 lines 0 comments Download
D third_party/sqlite/patches/0013-icu-Fix-buffer-overflow-when-case-mapping-expands-to.patch View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/sqlite/src/ext/icu/icu.c View 2 chunks +21 lines, -32 lines 0 comments Download
M third_party/sqlite/src/test/icu.test View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jungshik at Google
We want to have this change (that fixes uppercasing/lowercasing of an empty string) in M50. ...
4 years, 8 months ago (2016-04-06 22:27:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866753005/1
4 years, 8 months ago (2016-04-06 23:06:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 02:23:31 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8f7233f06c51fcec01dbacf92dfe7c1ec14c25f Cr-Commit-Position: refs/heads/master@{#385621}
4 years, 8 months ago (2016-04-07 02:25:36 UTC) #6
Scott Hess - ex-Googler
4 years, 8 months ago (2016-04-11 21:55:55 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698