Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issue 1880223002: Add the missing text input state tracking code to RenderWidgetHostViewMac. (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Add the missing text input state tracking code to RenderWidgetHostViewMac. Following the fix for crbug.com/578167 (CL 1652483002), a small part of the Mac related code was removed due to bad merging (after Patch 7). This CL fixes the issue by storing the new values of text input state in RenderWidgetHostViewMac as reported by the WebContentsImpl. BUG=601738 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1878523002 Cr-Commit-Position: refs/heads/master@{#386504} (cherry picked from commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
EhsanK
Could not figure out fixing merge conflict using git drover. So I used cherry-pick again. ...
4 years, 8 months ago (2016-04-12 18:32:45 UTC) #2
Charlie Reis
Thanks, LGTM. You can put the following lines in the CL description and CQ it, ...
4 years, 8 months ago (2016-04-12 18:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880223002/1
4 years, 8 months ago (2016-04-12 19:26:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 19:34:03 UTC) #8
EhsanK
4 years, 8 months ago (2016-04-15 19:30:54 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1888453009/ by ekaramad@chromium.org.

The reason for reverting is: This is needed to revert 
https://codereview.chromium.org/1652483002/. The original CL caused many
regressions.

BUG=601738,601570,602144,602954,603209,603676,603886,602926,602488.

Powered by Google App Engine
This is Rietveld 408576698