[Mac] Make Omnibox a little bit transparent.

[Edit] Uses same opaque as Windows OB2 code, not 90%.

[Mac] Make Omnibox a little bit transparent.

Randomly chose 90% opaque.  For some reason -controlColor didn't work
right anymore for hovered background, switch to -controlHighlightColor
(which sounds closer to the point anyhow).

http://crbug.com/20679
TEST=Omnibox popup should be slightly transparent, but not annoyingly so.

[rohitrao (ping after 24h), 2009-09-03 17:42:40]

LGTM

Per comment in the bug, double-check with Ben first to make sure we want this.

[Scott Hess - ex-Googler, 2009-09-03 18:05:46]

Ben did the transparency on Windows, so I've been assuming +1.

On Thu, Sep 3, 2009 at 10:42 AM, <rohitrao@chromium.org> wrote:
> LGTM
>
> Per comment in the bug, double-check with Ben first to make sure we want
> this.
>
> http://codereview.chromium.org/188014
>

[Scott Hess - ex-Googler, 2009-09-03 23:00:35]

Peter, I don't see Ben around, WDYT?

On Thu, Sep 3, 2009 at 11:05 AM, Scott Hess<shess@chromium.org> wrote:
> Ben did the transparency on Windows, so I've been assuming +1.
>
> On Thu, Sep 3, 2009 at 10:42 AM, <rohitrao@chromium.org> wrote:
>> LGTM
>>
>> Per comment in the bug, double-check with Ben first to make sure we want
>> this.
>>
>> http://codereview.chromium.org/188014
>>
>

[Peter Kasting, 2009-09-03 23:01:51]

http://codereview.chromium.org/188014/diff/2001/2002
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right):

http://codereview.chromium.org/188014/diff/2001/2002#newcode34
Line 34: // http://codereview.chromium.org/113242 is the result.
Don't reference codereview links in source.  Reference other source code.

I also take issue with "Windows experimented and" since it's pretty much untrue.

Just say "This value matches Windows; see autocomplete_popup_contents_view.cc."

[Scott Hess - ex-Googler, 2009-09-03 23:09:42]

Peter,

Was mostly looking for a +1 on the "What does Ben think?" question from the bug,
so I can put this to bed for Labor Day.  Since Ben added the transparency for
Windows, and this bug is from a Mac-team person, seems like +1 to me.

Thanks,
scott

http://codereview.chromium.org/188014/diff/2001/2002
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right):

http://codereview.chromium.org/188014/diff/2001/2002#newcode34
Line 34: // http://codereview.chromium.org/113242 is the result.
On 2009/09/03 23:01:51, Peter Kasting wrote:
> Don't reference codereview links in source.  Reference other source code.
> 
> I also take issue with "Windows experimented and" since it's pretty much
untrue.

That's why I referenced the review and not the code.

> Just say "This value matches Windows; see
autocomplete_popup_contents_view.cc."

Done.

[Peter Kasting, 2009-09-03 23:19:20]

On 2009/09/03 23:09:42, shess wrote:
> Was mostly looking for a +1 on the "What does Ben think?" question from the
bug,
> so I can put this to bed for Labor Day.

I have no idea what Ben thinks of the Mac transparency question.  Does it
matter?  Check in something and see what he thinks when he gets back.

LGTM