Fix some issues with the omnibox2 popup:...

Fix some issues with the omnibox2 popup:

- turn off transparency when glass isn't active
- make transparency when glass is active more opaque
- decrease the size of text to match the current omnibox popup
- make dim text in highlighted rows invert.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16003

[Peter Kasting, 2009-05-12 18:38:09]

http://codereview.chromium.org/113242/diff/1/2
File chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/113242/diff/1/2#newcode42
Line 42: static const int kGlassPopupTransparency = 245;
I still wonder if the transparency is buying you anything at this point, but OK

http://codereview.chromium.org/113242/diff/1/2#newcode522
Line 522: if (!selected && style & ACMatchClassification::DIM)
This looks goofy.  "if (!selected) ... return selected ? ..."  It looks like the
old code is correct and the new code is wrong?

[Ben Goodger (Google), 2009-05-12 22:13:28]

Slightly more transparent now. And removed the retarded code.

[Peter Kasting, 2009-05-12 22:17:42]

So, as-is, this doesn't actually do anything to "dimmed" selected text.  Is it
still hard-to-read, then?  Or was that screenshot someone showed just bogus?

http://codereview.chromium.org/113242/diff/6/1004
File chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/113242/diff/6/1004#newcode42
Line 42: static const int kGlassPopupTransparency = 240;
I don't understand.  Why did you make this 240?  245 was better.  255 would have
been even better.  I was trying to say that I don't see what being slightly
transparent buys you and you responded by making it more transparent.  If you
MUST keep this code please make it 245.  Or 250.  Or 254.

[Peter Kasting, 2009-05-12 23:42:02]

LGTM if you take out the dim text comment in the description.  I would still
prefer your original 245 to 240 :)