Enable /GL for all targets in Official (behind a flag)

Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked out 2 different revisions of Chrome and did 2 builds for each one, one WPO and one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)

non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB

WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
Committed: https://crrev.com/ea6b4cf8e486d9e8321030cde31024e7662130d5
Cr-Commit-Position: refs/heads/master@{#390779}

[Sébastien Marchand, 2016-04-18 16:33:48]

Description was changed from

==========
Use /GL everywhere for the PGO builds.
==========

to

==========
Enable /GL for all targets in Official
==========

[Sébastien Marchand, 2016-04-18 16:33:48]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org, scottmg@chromium.org

[Sébastien Marchand, 2016-04-18 16:34:29]

Description was changed from

==========
Enable /GL for all targets in Official
==========

to

==========
Enable /GL for all targets in Official

BUG=490934
==========

[Sébastien Marchand, 2016-04-18 16:34:56]

PTAL (won't land this before getting approval).

[Sébastien Marchand, 2016-04-18 16:35:10]

Description was changed from

==========
Enable /GL for all targets in Official

BUG=490934
==========

to

==========
Enable /GL for all targets in Official

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

[scottmg, 2016-04-18 16:47:26]

Corresponding GN change?

(VCLinkerTool is always on from what I can see, so this lgtm.)

[Sébastien Marchand, 2016-04-18 16:49:16]

Dang, Bruce sent me a reminder about this last week, so I've no excuse :), I'll
submit a new patch with the corresponding GN change.

[Sébastien Marchand, 2016-04-26 21:33:22]

Here's the GN config for this, after landing this I'll need to land a change in
ffmpeg to use the new 'optimize_no_wpo' config.

[scottmg, 2016-04-26 21:39:10]

lgtm, but I guess that means is_official_build GN will be broken until ffmpeg
lands and rolls, right?

[brucedawson, 2016-04-26 21:41:04]

On 2016/04/26 21:39:10, scottmg wrote:
> lgtm, but I guess that means is_official_build GN will be broken until ffmpeg
> lands and rolls, right?

Can you do it in three parts? One to land the add optimize_no_wpo, one to add
that to ffmpeg (well, two I guess since you have to roll it) and then a third
that adds the rest of it? That also makes reverting this change if needed
easier.

[Sébastien Marchand, 2016-04-26 21:42:49]

Yeah, I'll split this in several CL to avoid breaking this config :)

[Sébastien Marchand, 2016-04-28 21:04:14]

Description was changed from

==========
Enable /GL for all targets in Official

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

to

==========
Enable /GL for all targets in Official

DO NOT COMMIT until we've decided that we want it.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

[Sébastien Marchand, 2016-04-28 21:34:02]

Description was changed from

==========
Enable /GL for all targets in Official

DO NOT COMMIT until we've decided that we want it.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

to

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

[Sébastien Marchand, 2016-04-28 21:34:03]

sebmarchand@chromium.org changed reviewers:
+ dalecurtis@chromium.org, piman@chromium.org

[Sébastien Marchand, 2016-04-28 21:39:06]

Description was changed from

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

to

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

[Sébastien Marchand, 2016-04-28 21:40:16]

Patchset #7 (id:120001) has been deleted

[Sébastien Marchand, 2016-04-28 21:40:22]

Patchset #6 (id:100001) has been deleted

[Sébastien Marchand, 2016-04-28 21:40:58]

PTAL.

[DaleCurtis, 2016-04-28 21:51:05]

lgtm

[piman, 2016-04-28 23:32:45]

lgtm

[brucedawson, 2016-04-29 00:06:13]

Did you try adding /LTCG to the arflags and linker flags for the gn build, to
reduce warnings?

https://codereview.chromium.org/1880113003/diff/140001/third_party/mesa/BUILD.gn
File third_party/mesa/BUILD.gn (right):

https://codereview.chromium.org/1880113003/diff/140001/third_party/mesa/BUILD...
third_party/mesa/BUILD.gn:149: # Mesa is ever rolled and the warnings is fixed.
nit: warnings -> warning (or is -> are)

https://codereview.chromium.org/1880113003/diff/140001/third_party/yasm/BUILD.gn
File third_party/yasm/BUILD.gn (right):

https://codereview.chromium.org/1880113003/diff/140001/third_party/yasm/BUILD...
third_party/yasm/BUILD.gn:300: # Disable the WPO for yasm: crbug.com/604808
the WPO -> WPO

[Sébastien Marchand, 2016-04-29 14:15:39]

No, I'll tune the arflags/ldflags in a follow up CL (I'll clean it for all the
configurations: non-official, official without WPO, official with WPO; both on
Gyp and GN).

https://codereview.chromium.org/1880113003/diff/140001/third_party/mesa/BUILD.gn
File third_party/mesa/BUILD.gn (right):

https://codereview.chromium.org/1880113003/diff/140001/third_party/mesa/BUILD...
third_party/mesa/BUILD.gn:149: # Mesa is ever rolled and the warnings is fixed.
On 2016/04/29 00:06:13, brucedawson wrote:
> nit: warnings -> warning (or is -> are)

Done.

https://codereview.chromium.org/1880113003/diff/140001/third_party/yasm/BUILD.gn
File third_party/yasm/BUILD.gn (right):

https://codereview.chromium.org/1880113003/diff/140001/third_party/yasm/BUILD...
third_party/yasm/BUILD.gn:300: # Disable the WPO for yasm: crbug.com/604808
On 2016/04/29 00:06:13, brucedawson wrote:
> the WPO -> WPO

Done.

[brucedawson, 2016-04-29 20:25:21]

lgtm

[Sébastien Marchand, 2016-04-29 20:47:54]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-04-29 20:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, dalecurtis@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1880113003/#ps180001
(title: "Fix")

[commit-bot: I haz the power, 2016-04-29 20:48:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880113003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880113003/180001

[commit-bot: I haz the power, 2016-04-29 22:06:39]

Description was changed from

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

to

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

[commit-bot: I haz the power, 2016-04-29 22:06:40]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-04-30 17:29:31]

Patchset 8 (id:??) landed as
https://crrev.com/ea6b4cf8e486d9e8321030cde31024e7662130d5
Cr-Commit-Position: refs/heads/master@{#390779}

[commit-bot: I haz the power, 2016-04-30 18:03:02]

Description was changed from

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)
 
non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB


WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934
==========

to

==========
Enable /GL for all targets in Official (behind a flag)

This is controlled by the full_wpo_on_official GYP/GN flag.

The plan is to use this flag to do an experiment on Dev.

I've done some local tests regarding the impact on the delta patches (I checked
out 2 different revisions of Chrome and did 2 builds for each one, one WPO and
one not), here's the numbers:

Normal 1 (non-WPO):
chrome.dll: 35274.5 KB
chrome_child.dll: 43636 KB

Normal 2 (non-WPO) :
chrome.dll: 35405 KB
chrome_child.dll: 43792 KB

WPO 1:
chrome.dll: 34944.5 KB (-330 KB)
chrome_child.dll: 44569 KB (+933 KB)

WPO 2:
chrome.dll: 35066 KB (-339 KB)
chrome_child.dll 44710.5 KB (+918.5 KB)

non-WPO 1 -> non-WPO 2:
patch: 6205.23 KB
patch.7z: 2765.42 KB

WPO 1 -> WPO 2:
patch: 6640.88 KB (+435.65 KB)
patch.7z: 2951.07 KB (+185.65 KB)

BUG=490934

Committed: https://crrev.com/ea6b4cf8e486d9e8321030cde31024e7662130d5
Cr-Commit-Position: refs/heads/master@{#390779}
==========