Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1880113003: Enable /GL for all targets in Official (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 3ee4412ed255fbde3e0b94f81b767bd353851eac..ce59309b81eb68d94aa1c26d40fdd0cd41fdab58 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1233,12 +1233,9 @@ if (is_win) {
# Default "optimization on" config.
config("optimize") {
if (is_win) {
- # TODO(sebmarchand): Enable this once we've decided to ship with full WPO
- # and when the change to the incompatible projects (FFmpeg and Yasm) have
- # have been committed.
- #if (is_official_build) {
- # common_optimize_on_cflags += [ "/GL" ]
- #}
+ if (is_official_build && full_wpo_on_official) {
+ common_optimize_on_cflags += [ "/GL" ]
+ }
# Favor size over speed, /O1 must be before the common flags. The GYP
# build also specifies /Os and /GF but these are implied by /O1.
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698