Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 1880043002: Add a ContentSettingsPattern test for "*" vs. a site-scoped pattern. (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
dmurph
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a ContentSettingsPattern test for "*" vs. a site-scoped pattern. We have tests for "*".Compare(Wildcard()) == IDENTITY and for Wildcard().Compare("[*.]google.com") == SUCCESSOR. Assuming the comparison is transitive, it should hold that "*".Compare("[*.]google.com") == SUCCESSOR. This CL adds an explicit test case, so that we know that the comparison is, in this case, in fact transitive. BUG=602470 Committed: https://crrev.com/69745e4858c876f6c2329266c28f01a35a41ea6d Cr-Commit-Position: refs/heads/master@{#386936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M components/content_settings/core/common/content_settings_pattern_unittest.cc View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
msramek
Hi Dan, please have a look! I cannot reproduce your bug, and I'm adding a ...
4 years, 8 months ago (2016-04-12 09:19:43 UTC) #2
dmurph
On 2016/04/12 at 09:19:43, msramek wrote: > Hi Dan, > > please have a look! ...
4 years, 8 months ago (2016-04-12 18:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880043002/1
4 years, 8 months ago (2016-04-13 08:14:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 08:19:15 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 08:20:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69745e4858c876f6c2329266c28f01a35a41ea6d
Cr-Commit-Position: refs/heads/master@{#386936}

Powered by Google App Engine
This is Rietveld 408576698