Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: components/content_settings/core/common/content_settings_pattern_unittest.cc

Issue 1880043002: Add a ContentSettingsPattern test for "*" vs. a site-scoped pattern. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/common/content_settings_pattern_unittest.cc
diff --git a/components/content_settings/core/common/content_settings_pattern_unittest.cc b/components/content_settings/core/common/content_settings_pattern_unittest.cc
index c21658df74cef338dfa6f428c4cd849120f61e03..74e601979446d3c2ef185b6f358f03d05b2ed5f6 100644
--- a/components/content_settings/core/common/content_settings_pattern_unittest.cc
+++ b/components/content_settings/core/common/content_settings_pattern_unittest.cc
@@ -620,25 +620,38 @@ TEST(ContentSettingsPatternTest, Compare) {
EXPECT_EQ(ContentSettingsPattern::SUCCESSOR,
Pattern("https://mail.google.com:*").Compare(
Pattern("*://mail.google.com:80")));
+}
- // Test the wildcard pattern.
+TEST(ContentSettingsPatternTest, CompareWithWildcard) {
EXPECT_EQ(ContentSettingsPattern::IDENTITY,
ContentSettingsPattern::Wildcard().Compare(
ContentSettingsPattern::Wildcard()));
+ EXPECT_EQ(ContentSettingsPattern::IDENTITY,
+ ContentSettingsPattern::Wildcard().Compare(Pattern("*")));
EXPECT_EQ(ContentSettingsPattern::PREDECESSOR,
Pattern("[*.]google.com").Compare(
ContentSettingsPattern::Wildcard()));
+ EXPECT_EQ(ContentSettingsPattern::PREDECESSOR,
+ Pattern("[*.]google.com").Compare(Pattern("*")));
+
EXPECT_EQ(ContentSettingsPattern::SUCCESSOR,
ContentSettingsPattern::Wildcard().Compare(
Pattern("[*.]google.com")));
+ EXPECT_EQ(ContentSettingsPattern::SUCCESSOR,
+ Pattern("*").Compare(Pattern("[*.]google.com")));
EXPECT_EQ(ContentSettingsPattern::PREDECESSOR,
Pattern("mail.google.com").Compare(
ContentSettingsPattern::Wildcard()));
+ EXPECT_EQ(ContentSettingsPattern::PREDECESSOR,
+ Pattern("mail.google.com").Compare(Pattern("*")));
+
EXPECT_EQ(ContentSettingsPattern::SUCCESSOR,
ContentSettingsPattern::Wildcard().Compare(
Pattern("mail.google.com")));
+ EXPECT_EQ(ContentSettingsPattern::SUCCESSOR,
+ Pattern("*").Compare(Pattern("mail.google.com")));
}
// Legacy tests to ensure backwards compatibility.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698