Move StringHash.h include to OriginTrialContext.h

Move StringHash.h include to OriginTrialContext.h

This is a follow-up patch for r386009.

We added StringHash.h include in OriginTrial.h to fix build before.
However, this is used for HashSet<String>, and actually
OriginTrialContext.h has HashSet<String>.

So, we should have added StirngHash.h in OriginTrialContext.h
instead of OriginTrials.h.

BUG=601282
Committed: https://crrev.com/079a5f825dc266bc78beab35ba1baa54fb363088
Cr-Commit-Position: refs/heads/master@{#387535}

[shinyak, 2016-04-12 05:23:53]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 05:23:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879993002/1

[shinyak, 2016-04-12 05:30:44]

shinyak@chromium.org changed reviewers:
+ iclelland@chromium.org, mek@chromium.org

[shinyak, 2016-04-12 05:31:16]

Hi, this is a follow-up patch for https://codereview.chromium.org/1863323004
Could you review this?

[commit-bot: I haz the power, 2016-04-12 06:54:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 06:54:10]

Dry run: This issue passed the CQ dry run.

[iclelland, 2016-04-12 12:59:56]

I'm still a bit confused... the StringHash header is needed to bring in
HashTraits<String>::isEmptyValue(), but that's not used in OriginTrials.cpp,
it's used to instantiate the HashSet<String> in OriginTrialContext.h, isn't it?

(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

[Marijn Kruisselbrink, 2016-04-13 22:37:38]

On 2016/04/12 at 12:59:56, iclelland wrote:
> I'm still a bit confused... the StringHash header is needed to bring in
HashTraits<String>::isEmptyValue(), but that's not used in OriginTrials.cpp,
it's used to instantiate the HashSet<String> in OriginTrialContext.h, isn't it?
> 
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

Hmm, good point... maybe somehow MSVC (incorrectly?) thinks it needs to be able
to fully instantiate OriginTrialContext and its HashSet<String> member. No idea
why that would only be the case for whatever configuration it was this was
failing on though, but if that's what is happening, moving the StringHash.h
include to OriginTrialContext.h might be the correct solution. Considering all
other compilers/platforms/configurations seem to not need this it still seems
like this might be a MSVC bug, but moving the include to OriginTrialContext.h
would still be better I think.

[shinyak, 2016-04-14 02:27:09]

oops, sorry. I'll work for this soon.

[shinyak, 2016-04-14 04:52:24]

Description was changed from

==========
Move StringHash.h include to cpp in OriginTrials.

This is a follow-up patch for r386009.
We don't need to put StringHash.h in header, but needed to put
in source file.

BUG=601282
==========

to

==========
Move StringHash.h include to OriginTrialContext.h
    
This is a follow-up patch for r386009.

We added StringHash.h include in OriginTrial.h to fix build before.
However, this is used for HashSet<String>, and actually
OriginTrialContext.h has HashSet<String>.

So, we should have added StirngHash.h in OriginTrialContext.h
instead of OriginTrials.h.

BUG=601282
==========

[shinyak, 2016-04-14 04:55:15]

shinyak@chromium.org changed reviewers:
+ rbyers@chromium.org

[shinyak, 2016-04-14 04:55:16]

PTAL?

[iclelland, 2016-04-14 15:39:55]

This lgtm, thanks!

[Marijn Kruisselbrink, 2016-04-14 16:53:55]

lgtm

[shinyak, 2016-04-15 01:58:06]

The CQ bit was checked by shinyak@chromium.org

[commit-bot: I haz the power, 2016-04-15 01:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879993002/20001

[commit-bot: I haz the power, 2016-04-15 02:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 02:05:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shinyak, 2016-04-15 02:15:00]

shinyak@chromium.org changed reviewers:
+ haraken@chromium.org

[shinyak, 2016-04-15 02:16:30]

+rbyers +haraken for OWNER review

because https://codereview.chromium.org/1635593004 is reviewed by rbyers and
haraken.

[haraken, 2016-04-15 02:29:25]

LGTM

[shinyak, 2016-04-15 02:35:43]

The CQ bit was checked by shinyak@chromium.org

[commit-bot: I haz the power, 2016-04-15 02:36:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879993002/20001

[commit-bot: I haz the power, 2016-04-15 03:16:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 03:18:33]

Description was changed from

==========
Move StringHash.h include to OriginTrialContext.h
    
This is a follow-up patch for r386009.

We added StringHash.h include in OriginTrial.h to fix build before.
However, this is used for HashSet<String>, and actually
OriginTrialContext.h has HashSet<String>.

So, we should have added StirngHash.h in OriginTrialContext.h
instead of OriginTrials.h.

BUG=601282
==========

to

==========
Move StringHash.h include to OriginTrialContext.h

This is a follow-up patch for r386009.

We added StringHash.h include in OriginTrial.h to fix build before.
However, this is used for HashSet<String>, and actually
OriginTrialContext.h has HashSet<String>.

So, we should have added StirngHash.h in OriginTrialContext.h
instead of OriginTrials.h.

BUG=601282

Committed: https://crrev.com/079a5f825dc266bc78beab35ba1baa54fb363088
Cr-Commit-Position: refs/heads/master@{#387535}
==========

[commit-bot: I haz the power, 2016-04-15 03:18:34]

Patchset 2 (id:??) landed as
https://crrev.com/079a5f825dc266bc78beab35ba1baa54fb363088
Cr-Commit-Position: refs/heads/master@{#387535}