Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1863323004:
Windows component build fix: OriginTraials.h (Closed)
|
Created:
4 years, 8 months ago by shinyak (Google) Modified:
4 years, 8 months ago CC:
blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWindows component build fix: OriginTraials.h
Fix the following error:
webcore_shared.OriginTrials.obj : error LNK2001: unresolved external
symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String>
::isEmptyValue(class WTF::String const &)"
(?isEmptyValue@?$HashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z)
TBR=iclelland@chromium.org,rbyers@chromium.org,mek@chromium.org
BUG=601282
Committed: https://crrev.com/a34111d476c333a6e7b182f0d703e67d8172d2d3
Cr-Commit-Position: refs/heads/master@{#386009}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Windows component build fix: OriginTraials.h Fix the following error: webcore_shared.OriginTrials.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String> ::isEmptyValue(class WTF::String const &)" (?isEmptyValue@?$HashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z) BUG=601282 ========== to ========== Windows component build fix: OriginTraials.h Fix the following error: webcore_shared.OriginTrials.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String> ::isEmptyValue(class WTF::String const &)" (?isEmptyValue@?$HashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z) TBR=iclelland@chromium.org,rbyers@chromium.org,mek@chromium.org BUG=601282 ==========
The CQ bit was checked by shinyak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863323004/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by shinyak@chromium.org
shinyak@chromium.org changed reviewers: + iclelland@chromium.org, mek@chromium.org, rbyers@chromium.org - shinyak@chromium.org
shinyak@chromium.org changed reviewers: + shinyak@chromium.org
The CQ bit was checked by shinyak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863323004/1
lgtm
The CQ bit was unchecked by shinyak@chromium.org
The CQ bit was checked by shinyak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863323004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Windows component build fix: OriginTraials.h Fix the following error: webcore_shared.OriginTrials.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String> ::isEmptyValue(class WTF::String const &)" (?isEmptyValue@?$HashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z) TBR=iclelland@chromium.org,rbyers@chromium.org,mek@chromium.org BUG=601282 ========== to ========== Windows component build fix: OriginTraials.h Fix the following error: webcore_shared.OriginTrials.obj : error LNK2001: unresolved external symbol "public: static bool __cdecl WTF::HashTraits<class WTF::String> ::isEmptyValue(class WTF::String const &)" (?isEmptyValue@?$HashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z) TBR=iclelland@chromium.org,rbyers@chromium.org,mek@chromium.org BUG=601282 Committed: https://crrev.com/a34111d476c333a6e7b182f0d703e67d8172d2d3 Cr-Commit-Position: refs/heads/master@{#386009} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a34111d476c333a6e7b182f0d703e67d8172d2d3 Cr-Commit-Position: refs/heads/master@{#386009}
Message was sent while issue was closed.
https://codereview.chromium.org/1863323004/diff/1/third_party/WebKit/Source/b... File third_party/WebKit/Source/build/scripts/templates/OriginTrials.h.tmpl (right): https://codereview.chromium.org/1863323004/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/OriginTrials.h.tmpl:8: #include "wtf/text/StringHash.h" I don't know why this error is just showing up now, but shouldn't this line actually be in OriginTrialContext.cpp? (It looks to me like, if it was going to be a problem, it would have surfaced in https://codereview.chromium.org/1739163004, when I actually added the HashSet<String>)
Message was sent while issue was closed.
https://codereview.chromium.org/1863323004/diff/1/third_party/WebKit/Source/b... File third_party/WebKit/Source/build/scripts/templates/OriginTrials.h.tmpl (right): https://codereview.chromium.org/1863323004/diff/1/third_party/WebKit/Source/b... third_party/WebKit/Source/build/scripts/templates/OriginTrials.h.tmpl:8: #include "wtf/text/StringHash.h" On 2016/04/08 at 14:07:56, iclelland wrote: > I don't know why this error is just showing up now, but shouldn't this line actually be in OriginTrialContext.cpp? > > (It looks to me like, if it was going to be a problem, it would have surfaced in https://codereview.chromium.org/1739163004, when I actually added the HashSet<String>) Ah, sorry for late response. I'd like to fix this soon. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
