Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187993002: Remove the MultiProcessTest::SpawnChild() that as an fds_to_map argument. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Remove the MultiProcessTest::SpawnChild() that as an fds_to_map argument. It's POSIX-only and redundant. R=phajdan.jr@chromium.org TBR=brettw@chromium.org,jam@chromium.org,gene@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255289

Patch Set 1 #

Patch Set 2 : stupid chunks #

Patch Set 3 : 500 #

Patch Set 4 : 500 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M base/process/process_util_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/test/multiprocess_test.h View 1 chunk +0 lines, -8 lines 0 comments Download
M base/test/multiprocess_test.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ipc/ipc_test_base.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-05 18:32:38 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 9 months ago (2014-03-05 19:11:44 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-05 20:37:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/187993002/50001
6 years, 9 months ago (2014-03-05 20:38:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 21:04:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53698
6 years, 9 months ago (2014-03-05 21:04:58 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-05 21:05:19 UTC) #7
viettrungluu
OWNERS TBRs: brettw -> base jam -> ipc gene -> cloud_print
6 years, 9 months ago (2014-03-05 21:05:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/187993002/50001
6 years, 9 months ago (2014-03-05 21:07:14 UTC) #9
viettrungluu
On 2014/03/05 21:05:55, viettrungluu wrote: > OWNERS TBRs: > brettw -> base > jam -> ...
6 years, 9 months ago (2014-03-05 21:13:35 UTC) #10
jam
lgtm
6 years, 9 months ago (2014-03-05 22:40:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/187993002/50001
6 years, 9 months ago (2014-03-06 00:01:31 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:46:34 UTC) #13
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156195
6 years, 9 months ago (2014-03-06 01:46:34 UTC) #14
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-06 06:32:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/187993002/50001
6 years, 9 months ago (2014-03-06 06:32:31 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:21:45 UTC) #17
Message was sent while issue was closed. 
Change committed as 255289

Powered by Google App Engine
This is Rietveld 408576698