chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc - Issue 187993002: Remove the MultiProcessTest::SpawnChild() that as an fds_to_map argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 187993002: Remove the MultiProcessTest::SpawnChild() that as an fds_to_map argument. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 500 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

index e5c89874b5436307654671849c4d57952171c200..2d4e196e83e63cf4d17cddae82bfa32b3aa8118d 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

@@ -432,7 +432,9 @@ base::ProcessHandle CloudPrintProxyPolicyStartupTest::Launch(

ipc_file_list.push_back(std::make_pair(

startup_channel_->TakeClientFileDescriptor(),

kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor));

- base::ProcessHandle handle = SpawnChild(name, ipc_file_list, false);

+ base::LaunchOptions options;

+ options.fds_to_remap = &ipc_file_list;

+ base::ProcessHandle handle = SpawnChildWithOptions(name, options, false);

#else

base::ProcessHandle handle = SpawnChild(name, false);

#endif

« no previous file with comments | « base/test/multiprocess_test.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »